Fix window not showing for some users #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t waiting for network requests
wendytang
approved these changes
Jun 17, 2025
Collaborator
Author
|
.bundle |
Contributor
|
- Add validation in recentDirs.ts to filter out non-existent directories and files - Prevent files from being added to recent directories list - Add fallback to home directory in goosed.ts when invalid directory is provided - Fix openDirectoryDialog to use parent directory when file is selected - Add proper validation and error handling for directory paths This fixes the issue where goosed would fail to launch when trying to use a CSV file path or other invalid directory as the working directory.
- Use lstatSync instead of statSync to detect and reject symlinks - Prevent symlinks from being added to recent directories for security - Avoid logging full paths in error messages to prevent information disclosure - Add symlink detection in file dialog handling - Maintain existing path traversal protections These changes prevent potential security issues where malicious symlinks could be used to access directories outside the intended scope.
zanesq
commented
Jun 17, 2025
| go 1.23.0 | ||
|
|
||
| require ( | ||
| go.temporal.io/api v1.44.1 |
Collaborator
Author
There was a problem hiding this comment.
cherry picked @Kvadratni fix to get builds working again
Kvadratni
approved these changes
Jun 17, 2025
Collaborator
Author
|
.bundle |
2 similar comments
Collaborator
Author
|
.bundle |
Collaborator
Author
|
.bundle |
Contributor
macOS ARM64 Desktop App (Apple Silicon)📱 Download macOS Desktop App (arm64, signed) Instructions: This link is provided by nightly.link and will work even if you're not logged into GitHub. |
tiensi
pushed a commit
to tiensi/goose
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Max Novich <mnovich@squareup.com>
michaelneale
added a commit
that referenced
this pull request
Jun 18, 2025
* main: (26 commits) chore(release): release version 1.0.29 (#2978) [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972) fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870) fix: remove computer controller presentation (#2956) Fix GitHub Copilot Provider Config (#2955) Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959) Docs: Recipe settings (#2970) feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971) feat: alphabetize extensions in goose CLI (#2966) switch roles on condition for windows (#2975) fix version param for canary (#2974) enabling windows builds with code signing (#2968) feat(cli): add system prompt parameter to run command (#2253) Fix window not showing for some users (#2967) Add documentation for running with Ramalama local model serving in OCI Containers (#1973) Reddit MCP Server Tutorial (#2949) [fix] goose not quitting app completely (#2950) Opopadich/issue 1625 (#2904) chore(deps): bump go.temporal.io/api from 1.24.0 to 1.44.1 in /temporal-service (#2837) feat: add newline at end of file writes (#2221) ...
laanak08
added a commit
that referenced
this pull request
Jun 18, 2025
* main: (28 commits) feat: optional fast edit models (#2580) feat: Add lead-worker model selection and real-time model display in GUI (#2964) chore(release): release version 1.0.29 (#2978) [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972) fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870) fix: remove computer controller presentation (#2956) Fix GitHub Copilot Provider Config (#2955) Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959) Docs: Recipe settings (#2970) feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971) feat: alphabetize extensions in goose CLI (#2966) switch roles on condition for windows (#2975) fix version param for canary (#2974) enabling windows builds with code signing (#2968) feat(cli): add system prompt parameter to run command (#2253) Fix window not showing for some users (#2967) Add documentation for running with Ramalama local model serving in OCI Containers (#1973) Reddit MCP Server Tutorial (#2949) [fix] goose not quitting app completely (#2950) Opopadich/issue 1625 (#2904) ...
btdeviant
pushed a commit
to btdeviant/goose
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Max Novich <mnovich@squareup.com>
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Co-authored-by: Max Novich <mnovich@squareup.com> Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Co-authored-by: Max Novich <mnovich@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the users that had the issue was from goose trying to launch from a nonexistent previous directory or file path that was crashing the server.