Skip to content

Conversation

@lifeizhou-ap
Copy link
Collaborator

Why
Without the encoding/decode uri, the deeplink generated for recipe containing "```" cannot be decoded on Desktop side. It will show error. Example recipe

What
Added the uri encoding on Rust side and uri decoding on Desktop side to handle the deeplink for recipe.

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@lifeizhou-ap lifeizhou-ap merged commit f23fc19 into main Jun 10, 2025
7 checks passed
@lifeizhou-ap lifeizhou-ap deleted the lifei/fix-recipe-url-encoding branch June 10, 2025 13:02
michaelneale added a commit that referenced this pull request Jun 11, 2025
* main:
  Fix: Adding dark mode support for recipe modal (#2853)
  fix just (#2849)
  add temporal service to builds. (#2842)
  fix: added url encoding and decoding for goose recipe url (#2845)
opdich added a commit to opdich/goose that referenced this pull request Jun 11, 2025
* upstream/main: (26 commits)
  docs: add CLI token usage (block#2857)
  Add Linux desktop package building workflow (block#2826)
  fix: large sessions summarize/truncate  (block#2846)
  Fix: Adding dark mode support for recipe modal (block#2853)
  fix just (block#2849)
  add temporal service to builds. (block#2842)
  fix: added url encoding and decoding for goose recipe url (block#2845)
  claude 4 listing (block#2843)
  fix: Use the existing spinner in interactive mode (block#2829)
  chore(release): release version 1.0.27 (block#2844)
  Revert "Mnovich/temporal scheduler (block#2745)" (block#2839)
  chore(release): release version 1.0.26 (block#2833)
  Removed ui-v2 directory and updated project to use node in hermit and readme (block#2831)
  Mnovich/temporal scheduler (block#2745)
  fix: intel builds (block#2832)
  chore(release): release version 1.0.25 (block#2811)
  Nostrbook MCP is now on npm (block#2816)
  Update macOS install guide with Homebrew instructions (block#2823)
  remember window position (block#2808)
  feat(ui): put the scheduler behind an alpha (block#2810)
  ...
laanak08 added a commit that referenced this pull request Jun 16, 2025
* main:
  docs: add CLI token usage (#2857)
  Add Linux desktop package building workflow (#2826)
  fix: large sessions summarize/truncate  (#2846)
  Fix: Adding dark mode support for recipe modal (#2853)
  fix just (#2849)
  add temporal service to builds. (#2842)
  fix: added url encoding and decoding for goose recipe url (#2845)
  claude 4 listing (#2843)
  fix: Use the existing spinner in interactive mode (#2829)
  chore(release): release version 1.0.27 (#2844)
  Revert "Mnovich/temporal scheduler (#2745)" (#2839)
  chore(release): release version 1.0.26 (#2833)
  Removed ui-v2 directory and updated project to use node in hermit and readme (#2831)
  Mnovich/temporal scheduler (#2745)
  fix: intel builds (#2832)
  chore(release): release version 1.0.25 (#2811)
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants