Skip to content

fix: added url encoding and decoding for goose recipe url #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeizhou-ap merged 1 commit into from
Jun 10, 2025
Merged

fix: added url encoding and decoding for goose recipe url #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/goose-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ http = "1.0"
webbrowser = "1.0"

indicatif = "0.17.11"
urlencoding = "2"

[target.'cfg(target_os = "windows")'.dependencies]
winapi = { version = "0.3", features = ["wincred"] }
Expand Down
3 changes: 2 additions & 1 deletion crates/goose-cli/src/commands/recipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ pub fn handle_deeplink(recipe_name: &str) -> Result<()> {
style("✓").green().bold(),
recipe.title
);
println!("goose://recipe?config={}", deeplink);
let url_safe = urlencoding::encode(&deeplink);
println!("goose://recipe?config={}", url_safe);
}
Ok(())
}
Expand Down
3 changes: 2 additions & 1 deletion ui/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ app.on('open-url', async (_event, url) => {
if (parsedUrl.hostname === 'bot' || parsedUrl.hostname === 'recipe') {
let recipeConfig = null;
const configParam = parsedUrl.searchParams.get('config');
const base64 = decodeURIComponent(configParam || '');
if (configParam) {
try {
recipeConfig = JSON.parse(Buffer.from(configParam, 'base64').toString('utf-8'));
recipeConfig = JSON.parse(Buffer.from(base64, 'base64').toString('utf-8'));
} catch (e) {
console.error('Failed to parse bot config:', e);
}
Expand Down
Loading