fix: Use the existing spinner in interactive mode #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jamadeo much nicer. I note in non interactive mode it outputs still a bit too - is that intentional? this change looks great though. |
michaelneale
approved these changes
Jun 10, 2025
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 10, 2025
* main: (77 commits) claude 4 listing (#2843) fix: Use the existing spinner in interactive mode (#2829) chore(release): release version 1.0.27 (#2844) Revert "Mnovich/temporal scheduler (#2745)" (#2839) chore(release): release version 1.0.26 (#2833) Removed ui-v2 directory and updated project to use node in hermit and readme (#2831) Mnovich/temporal scheduler (#2745) fix: intel builds (#2832) chore(release): release version 1.0.25 (#2811) Nostrbook MCP is now on npm (#2816) Update macOS install guide with Homebrew instructions (#2823) remember window position (#2808) feat(ui): put the scheduler behind an alpha (#2810) debug config issues on windows (#2809) Add Speech MCP extension to extensions directory (#2807) Iand/blog goosehints metadata update (#2800) Iand/blog goosehints (#2798) blog post about goosehints and persistent context (#2796) [goose-llm] system prompt override (#2791) chore: small bit of a cleanup - removing unused dir (#2761) ...
michaelneale
added a commit
that referenced
this pull request
Jun 10, 2025
* main: claude 4 listing (#2843) fix: Use the existing spinner in interactive mode (#2829) chore(release): release version 1.0.27 (#2844) Revert "Mnovich/temporal scheduler (#2745)" (#2839) chore(release): release version 1.0.26 (#2833) Removed ui-v2 directory and updated project to use node in hermit and readme (#2831) Mnovich/temporal scheduler (#2745) fix: intel builds (#2832) chore(release): release version 1.0.25 (#2811) Nostrbook MCP is now on npm (#2816) Update macOS install guide with Homebrew instructions (#2823) remember window position (#2808) feat(ui): put the scheduler behind an alpha (#2810) debug config issues on windows (#2809) Add Speech MCP extension to extensions directory (#2807) Iand/blog goosehints metadata update (#2800) Iand/blog goosehints (#2798) blog post about goosehints and persistent context (#2796) [goose-llm] system prompt override (#2791) chore: small bit of a cleanup - removing unused dir (#2761)
Collaborator
Author
|
Thanks @michaelneale, yeah, when I run non-interactive I tend to still observe the output so it made sense to keep it in there, but I could also see the argument against. WDYT? |
opdich
added a commit
to opdich/goose
that referenced
this pull request
Jun 11, 2025
* upstream/main: (26 commits) docs: add CLI token usage (block#2857) Add Linux desktop package building workflow (block#2826) fix: large sessions summarize/truncate (block#2846) Fix: Adding dark mode support for recipe modal (block#2853) fix just (block#2849) add temporal service to builds. (block#2842) fix: added url encoding and decoding for goose recipe url (block#2845) claude 4 listing (block#2843) fix: Use the existing spinner in interactive mode (block#2829) chore(release): release version 1.0.27 (block#2844) Revert "Mnovich/temporal scheduler (block#2745)" (block#2839) chore(release): release version 1.0.26 (block#2833) Removed ui-v2 directory and updated project to use node in hermit and readme (block#2831) Mnovich/temporal scheduler (block#2745) fix: intel builds (block#2832) chore(release): release version 1.0.25 (block#2811) Nostrbook MCP is now on npm (block#2816) Update macOS install guide with Homebrew instructions (block#2823) remember window position (block#2808) feat(ui): put the scheduler behind an alpha (block#2810) ...
laanak08
added a commit
that referenced
this pull request
Jun 16, 2025
* main: docs: add CLI token usage (#2857) Add Linux desktop package building workflow (#2826) fix: large sessions summarize/truncate (#2846) Fix: Adding dark mode support for recipe modal (#2853) fix just (#2849) add temporal service to builds. (#2842) fix: added url encoding and decoding for goose recipe url (#2845) claude 4 listing (#2843) fix: Use the existing spinner in interactive mode (#2829) chore(release): release version 1.0.27 (#2844) Revert "Mnovich/temporal scheduler (#2745)" (#2839) chore(release): release version 1.0.26 (#2833) Removed ui-v2 directory and updated project to use node in hermit and readme (#2831) Mnovich/temporal scheduler (#2745) fix: intel builds (#2832) chore(release): release version 1.0.25 (#2811)
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up tool streaming output in interactive mode.
Before:
before.mov
After:
after.mov