Skip to content

Conversation

@alexhancock
Copy link
Collaborator

@alexhancock alexhancock commented Jun 2, 2025

I think this is an extra components/ui directory disconnected from the one in src/components/ui. Removing it and the contained popover component, but let me know if you were using it for something @nahiyankhan !

@alexhancock alexhancock requested a review from nahiyankhan June 2, 2025 19:58
Copy link

@inez inez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update description to match what's actually happening - removing file (ui/desktop/components/ui/popover.tsx), not just a dir

@alexhancock alexhancock merged commit c04373f into main Jun 5, 2025
7 checks passed
@alexhancock alexhancock deleted the alexhancock/remove-unused-components-ui branch June 5, 2025 14:58
@alexhancock alexhancock changed the title chore: small bit of a cleanup - removing unused dir chore: small bit of a cleanup - removing unused dir and component Jun 5, 2025
katzdave added a commit to katzdave/goose that referenced this pull request Jun 6, 2025
* upstream/main:
  Iand/blog goosehints metadata update (block#2800)
  Iand/blog goosehints (block#2798)
  blog post about goosehints and persistent context (block#2796)
  [goose-llm] system prompt override (block#2791)
  chore: small bit of a cleanup - removing unused dir (block#2761)
  feat: lead/worker model (block#2719)
  fix: pass ref in pr comment workflow (block#2777)
  feat: goose web for local terminal alternative (block#2718)
  chore: run CI on merge_group (block#2786)
lifeizhou-ap added a commit that referenced this pull request Jun 10, 2025
* main: (77 commits)
  claude 4 listing (#2843)
  fix: Use the existing spinner in interactive mode (#2829)
  chore(release): release version 1.0.27 (#2844)
  Revert "Mnovich/temporal scheduler (#2745)" (#2839)
  chore(release): release version 1.0.26 (#2833)
  Removed ui-v2 directory and updated project to use node in hermit and readme (#2831)
  Mnovich/temporal scheduler (#2745)
  fix: intel builds (#2832)
  chore(release): release version 1.0.25 (#2811)
  Nostrbook MCP is now on npm (#2816)
  Update macOS install guide with Homebrew instructions (#2823)
  remember window position (#2808)
  feat(ui): put the scheduler behind an alpha (#2810)
  debug config issues on windows (#2809)
  Add Speech MCP extension to extensions directory (#2807)
  Iand/blog goosehints metadata update (#2800)
  Iand/blog goosehints (#2798)
  blog post about goosehints and persistent context (#2796)
  [goose-llm] system prompt override (#2791)
  chore: small bit of a cleanup - removing unused dir (#2761)
  ...
michaelneale added a commit that referenced this pull request Jun 10, 2025
* main:
  claude 4 listing (#2843)
  fix: Use the existing spinner in interactive mode (#2829)
  chore(release): release version 1.0.27 (#2844)
  Revert "Mnovich/temporal scheduler (#2745)" (#2839)
  chore(release): release version 1.0.26 (#2833)
  Removed ui-v2 directory and updated project to use node in hermit and readme (#2831)
  Mnovich/temporal scheduler (#2745)
  fix: intel builds (#2832)
  chore(release): release version 1.0.25 (#2811)
  Nostrbook MCP is now on npm (#2816)
  Update macOS install guide with Homebrew instructions (#2823)
  remember window position (#2808)
  feat(ui): put the scheduler behind an alpha (#2810)
  debug config issues on windows (#2809)
  Add Speech MCP extension to extensions directory (#2807)
  Iand/blog goosehints metadata update (#2800)
  Iand/blog goosehints (#2798)
  blog post about goosehints and persistent context (#2796)
  [goose-llm] system prompt override (#2791)
  chore: small bit of a cleanup - removing unused dir (#2761)
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants