Fix build-cli workflow to use correct PR branch #2765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pr_number input parameter to build-cli.yml workflow - Fetch PR details and checkout correct branch/commit when building from PR comments - Maintain backward compatibility for non-PR builds (releases, canary) - Fixes issue where .build-cli command used main branch instead of PR branch This resolves the root cause that led to PR #2759 revert of Hermit integration. The build-cli workflow now properly uses the PR's branch code when triggered from PR comments, enabling safe re-introduction of Hermit toolchain management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #2754 (Hermit integration) was reverted in PR #2759 due to build failures. The root cause was that the build-cli workflow was using main branch code instead of the PR branch code when triggered from PR comments.
Solution
This PR fixes the GitHub Actions workflow to properly handle PR branch builds:
Changes Made:
Technical Details:
pr_numberinput parameter to build-cli.yml workflowTesting
Once merged, this can be tested by:
.build-clion the PRImpact
Next Steps
After this fix is confirmed working:
Fixes the core issue mentioned in PR #2759 revert.