feat: check tool annotation before permission check #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendytang
approved these changes
Apr 1, 2025
laanak08
added a commit
that referenced
this pull request
Apr 3, 2025
* main: fix: handle the case sensitive in mac screenshot name (#2021) ui: better env var ux (#2006) feat: add ANTHROPIC_HOST configuration for Anthropic in cli and UI (#1776) Fix function params (#2012) revert: "feat: allowlist optionally for goosed (#1848)" (#2010) # feat(providers): Add support for generic GCP Vertex AI Claude and Gemini models (#1909) fix: fix empty result for view tool response (#2011) Blog: Top MCP servers I use (#1951) docs: MCP for Nondevs Blog (#1910) styles: update markdown styles (#2005) fix(ollama): respect ollama URL and port (#2004) ui: refresh selected model (#2002) ui: fix radio button selection (#2001) use provider display names (#2000) ui: settings v2 click anywhere to exit models bottom bar (#1997) feat: better ErrorBoundary UI (#1993) feat: check tool annotation before permission check (#1957) fix: see last msg fully in shared session view (#1994)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check the read-only annotation in tool annotations, if annotation is none, we will use llm-as-a-judge when goose mode is smart approval. If read only hint is true, we directly skip the permission check to save cost and time.