Skip to content

Conversation

@uddhav
Copy link
Contributor

@uddhav uddhav commented Mar 28, 2025

This PR introduces support for generic Claude and Gemini model variants within the GCP Vertex AI provider. This allows Goose to handle potentially unknown or future model versions released by Google Cloud without requiring immediate code updates.

Avoids this error for manually configured GCP Vertex AI models.

Ran into this error: Execution error: Failed to parse model ID: gemini-2.5-pro-exp-03-25.

Please retry if you think this is a transient or recoverable error.

Changes:

  • Added Generic(String) variants to both ClaudeVersion and GeminiVersion enums to support arbitrary model names
  • Updated model parsing to match any model name starting with claude- or gemini-
  • Updated fmt::Display implementation to preserve exact model names for generic variants
  • Added comprehensive tests for the new generic model parsing functionality
  • Added the newly released gemini-2.5-pro-exp-03-25 model.

@uddhav uddhav marked this pull request as ready for review March 28, 2025 20:15
…GCP Vertex AI

- Add generic variants for Claude and Gemini model versions to handle unknown model names in GCP Vertex AI
- Match any model name starting with "claude-" or "gemini-" prefix
- Add specific support for the "gemini-2.5-pro-exp-03-25" model as a named variant
- Add comprehensive tests for generic model parsing
- Maintain backward compatibility with existing models
@uddhav uddhav force-pushed the gcp-vertex-ai-any-model branch from 2a00bfa to aa5cc34 Compare March 30, 2025 06:36
@yingjiehe-xyz
Copy link
Contributor

Thanks for the update! it looks good!

@yingjiehe-xyz yingjiehe-xyz merged commit 4846d15 into block:main Apr 2, 2025
6 checks passed
lily-de pushed a commit that referenced this pull request Apr 2, 2025
lily-de pushed a commit that referenced this pull request Apr 2, 2025
laanak08 added a commit that referenced this pull request Apr 3, 2025
* main:
  fix: handle the case sensitive in mac screenshot name (#2021)
  ui: better env var ux (#2006)
  feat: add ANTHROPIC_HOST configuration for Anthropic in cli and UI (#1776)
  Fix function params  (#2012)
  revert: "feat: allowlist optionally for goosed (#1848)"  (#2010)
  # feat(providers): Add support for generic GCP Vertex AI Claude and Gemini models (#1909)
  fix: fix empty result for view tool response (#2011)
  Blog: Top MCP servers I use  (#1951)
  docs: MCP for Nondevs Blog (#1910)
  styles: update markdown styles (#2005)
  fix(ollama): respect ollama URL and port (#2004)
  ui: refresh selected model (#2002)
  ui: fix radio button selection (#2001)
  use provider display names (#2000)
  ui: settings v2 click anywhere to exit models bottom bar (#1997)
  feat: better ErrorBoundary UI (#1993)
  feat: check tool annotation before permission check (#1957)
  fix: see last msg fully in shared session view (#1994)
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants