-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24] Tables Rewrite - Dashboard #378
Comments
great! |
These look amazing. Few comments
honestly I like having it all on one page with title and black space in between, but I'll manage w/o it too.
Hope this helps. cheers. |
|
re: what else can act as collateral? - from asset creation menu if you check smartcoin, can write in text for short backing collateral: https://i.imgur.com/XGm0ufl.png for example (no idea if works) re 5: as has been suggested before, wallet-model is extremely confusing and leads to most common questions in support. word "wallet" is used in "wallet model", bitshares.org/wallet, web wallet (which is what all web UI are), light wallet (software wallet, downloadable client has it directly in file name), and generally wallet is "A cryptocurrency wallet is a secure digital wallet used to store, send, and receive digital currency". generally, wallet is "where your money is". I have 50+ crypto and they have all generally referred to wallet as software and location in UI where you see your balances: most common wallet design: https://i.imgur.com/bY8j4if.jpg or e.g. steemit web wallet literally has a tab called wallet for balances. openledger.io (most used ui?) under simple mode writes out "wallet" at the top too. the only phrase that has the least business of having the word "wallet" in the name is "wallet-model" wallet model is extra confusing because people who are trying to get a wallet pick it because it's called wallet. account model users are confused how do they withdraw money to their wallet from the dex. bts predates a lot of crypto, but should be consistent with terminology to make it easier to understand. The main difference is in backup requirements (file) and having multiple accounts - hence I think "wallet model" should be renamed - "file model" or "multi-account file model" with the first option hidden unless advanced user. Someone restoring from a file will quite obviously figure out file one is the one to use. |
Regarding the wallet naming, I think we are stuck with it. I think if a user picks an account model and then sees their wallet balance, it's going to get very difficult to support them, whereas, their portfolio can be referred to as such whether they choose the wallet model or the account model. |
Colors: Top Left Holdings: 27384B |
Holdings vs Portfolio is confusing to me, they mean the same thing. |
Let's call is Estimated Value. This fits with the recent naming convention changes. I updated the mockups to reflect this. |
I really like the new design of these tables. One thing confuses me, though. What is the purpose of the Markets table? Unless I'm missing something, it really doesn't seem to belong here. |
Well, the problem is.... it doesn't really belong anywhere. Right now it's located above the hierarchy of a chosen account, which, for the majority of our users is kinda silly because they only have 1 account. This means that they have to migrate up in hierarchy to view the market and then choose their account after that. So..... I was thinking, why not just put the market in the dashboard? It's still available to all accounts but it's not in the awkward spot it's in now. |
The table layout of activity is very problematic due to the amount of different transaction types (~40). Trying to fit them all in a table will require a lot of columns, making it confusing imo. It also does not handle proposed transactions very well, I'll see if I can find an example of how that looks atm. Due to the amount of columns its also very bad for smaller screens and mobile, that's a general concern of tables. |
No idea what you mean by narrow fonts in the header. I used to have n/a for unknown prices, but nobody understood what that meant so I changed it.. The gap in the portfolio is between assets you actually have and the default list of assets that are shown so you can easily buy or trade them, they're shortcuts basically. |
I know it feels like I'm being really picky at this point, but it's my hope that we can set as many standards now as possible on these tables. Please increase the hours on this items to reflect your time worked. |
|
The sort order is by price, which is the only sorting that makes sense. |
Hrmmm, open orders being sorted on price? I would think grouped by market and then date makes more sense. The sort order should not change when switching the pricing pair. I hope you take some time to reconsider your opinion here. |
By markets first, then price. |
My fear is that when someone inverts the price, they will lose whatever row they might have been on and may end up canceling the wrong order. |
The market direction is persistent and consistent with your selection everywhere else, so I don't see why anyone would ever switch that direction more than once anyway. |
Sorting by price makes it look similar to a vertical orderbook, which at least to me makes a lot of sense.. |
I think this is about ready now, it's also taken a lot more time than the original estimate, at least 3 full days or 24 hours. |
I figured! |
In a portfolio view, it makes the most sense for your largest positions to be at the top, smallest at the bottom. So sorting descending by Value (not by Price) would really be best here.
|
@tbone-bts we are cutting off the features for now. This falls under sort order. Open a separate issue for allowing sortby. Thanks. |
I agree that allowing sortby is a different issue. But I was talking about the default sort order. @svk suggested default sort order should be by Price bc it's similar to order book...and I was pointing out that in a portfolio it should be sorted descending by Value of the holding. |
We were talking about open orders, not the portfolio. I agree it makes sense to sort the portfolio by value of the holdings, I'll have a look to see how difficult it would be to implement. |
Ah ok, your comment was directly after a post with an image of the Portfolio table. Threw me off. But thanks for clarifying! |
Merged |
The idea behind a tables rewrite is to change the look without worrying too much about functionality. This amounts to a facelift while establishing some best practices for the future. The wallet has a somewhat haphazard approach to accessing certain features. Some items are in a top menu and others are on a side menu. Side menus are notorious for wasting horizontal space. I think they should go away ultimately, but don't want to change so much at once that it confuses users. With that in mind, I'm going to submit a table concept for the Overview page. As you can see, I've suggested that we call it Dashboard instead.
Rather than the user scrolling down and accessing other menus to get to other areas, I've created pills at the top. Areas that contain balance detail also display the total balances in the pill for a glance.
You should notice that the functionality of the table is identical but instead of clickable text, we have meaningful icons. I have also created separate columns for symbols and quantities so our data lines up in a more pleasing way.
As you view this, realize that the top and side menus aren't visible in my mockup. This table would be displayed in place of:
As we get closer to consensus, I also need to propose a light themed version of this.
The text was updated successfully, but these errors were encountered: