Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24] Tables Rewrite - Dashboard #378

Closed
wmbutler opened this issue Sep 10, 2017 · 79 comments
Closed

[24] Tables Rewrite - Dashboard #378

wmbutler opened this issue Sep 10, 2017 · 79 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@wmbutler
Copy link
Contributor

wmbutler commented Sep 10, 2017

The idea behind a tables rewrite is to change the look without worrying too much about functionality. This amounts to a facelift while establishing some best practices for the future. The wallet has a somewhat haphazard approach to accessing certain features. Some items are in a top menu and others are on a side menu. Side menus are notorious for wasting horizontal space. I think they should go away ultimately, but don't want to change so much at once that it confuses users. With that in mind, I'm going to submit a table concept for the Overview page. As you can see, I've suggested that we call it Dashboard instead.

Rather than the user scrolling down and accessing other menus to get to other areas, I've created pills at the top. Areas that contain balance detail also display the total balances in the pill for a glance.

You should notice that the functionality of the table is identical but instead of clickable text, we have meaningful icons. I have also created separate columns for symbols and quantities so our data lines up in a more pleasing way.

screen shot 2017-09-19 at 2 31 14 pm

As you view this, realize that the top and side menus aren't visible in my mockup. This table would be displayed in place of:

screen shot 2017-09-10 at 6 17 11 pm

As we get closer to consensus, I also need to propose a light themed version of this.

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Sep 10, 2017
@wmbutler wmbutler added this to the 171001 milestone Sep 10, 2017
@btsfav
Copy link

btsfav commented Sep 11, 2017

great!

@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 11, 2017

Open Orders

screen shot 2017-10-02 at 7 22 35 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 11, 2017

Margin Positions (UPDATED)

screen shot 2017-10-03 at 6 51 39 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 12, 2017

Activity

screen shot 2017-09-20 at 9 59 15 pm

@o5j5vg55bv5hv5j5f8799f9

These look amazing.

Few comments

  1. whenever you estimate price of USD I think it should say "~" or "EST. USD" before number. B/c on non liquid assets this can be really random. specifically at the top
  2. not clear why in open orders you have asset 1 and asset 2 as the same, shouldn't they be pair specific orders?
  3. I don't understand what markets the markets tab shows
  4. margin positions - this one needs most work. units are jumping around here.
  • maybe switch places for 1st and 2nd columns and get rid of separator so it's clear DEBT is -8000 bitUSD. whenever you have units to the right of a number, number should be right adjusted and units left adjusted, so can even get rid of the separator between them. (see random space before BTS/bitUSD for e.g.)
  • Then collateral units need to be specified. I can't remember if it can be something other than BTS, but that needs mention in title of column like COLLATERAL (BTS) or to the right of the column. If to the right, might as well have two units there per debt. one in BTS and one in units used for ratio calculation marked as estimate. so for bitUSD it would say 460,000 BTS and right below it ~51341 bitUSD
  • need some more info of when getting liquidated here. easiest might be CURRENT PRICE next to CALL PRICE.
  • I simply don't understand what VALUE(USD) means here. Shouldn't it be like USD value of collateral minus USD value of debt? I assume this is the only place locked collateral would count for holdings calculation and not in portfolio. I can't get 1345 USD out of 8000 USD and 460k BTS collateral anyway.
  • update row adjustment seems pointless on all of them. should just be sorted by column
  • update position field is missing
  • very bottom does nice job of summing it up. could make it clearer by putting default units on it and summing up total debt in usd with negative sign, total collateral in usd with negative sign, and net difference for value where it does now (I think). both value column sum and addition of all collateral minus all debt should lead to same number at cross section where 700,000 is written now.

honestly I like having it all on one page with title and black space in between, but I'll manage w/o it too.

  1. since portfolio is where the coins you have right now are, available to send, maybe it makes sense to call it just "wallet". there's been some confusion about bitshares dex and where bitshares wallet is and whether people should withdraw from the dex to be safe. It's obvious but having the words wallet written somewhere might finally get people to understand this IS the "wallet". They are literally viewing their account on blockchain.

Hope this helps. cheers.

@wmbutler
Copy link
Contributor Author

  1. Maybe a blanket disclaimer somewhere. Easier and cleaner
  2. So there are 2 separate columns for those who want to export to a speadsheet. I'm open to combining them.
  3. Doh, posted the wrong image. Will repost.
  4. It's just a mock :)
    • Not sure I agree with numbers vs asset. I like to see the asset first.
    • What else can act as collateral?
    • That's the value of the collateral.
    • Not adding new features yet. Just changing the look of the tables. Patience grasshopper.
    • Value of the collateral (same as current data but with a different table style)
    • That allows the user to update their collateral position
    • See above
    • Units are in the header. Do we really need it at the bottom too?
  5. Wallet is a bad word because it might make people think they are in the wallet mode rather than account mode.

@o5j5vg55bv5hv5j5f8799f9
Copy link

o5j5vg55bv5hv5j5f8799f9 commented Sep 15, 2017

re: what else can act as collateral? - from asset creation menu if you check smartcoin, can write in text for short backing collateral: https://i.imgur.com/XGm0ufl.png for example (no idea if works)

re 5: as has been suggested before, wallet-model is extremely confusing and leads to most common questions in support. word "wallet" is used in "wallet model", bitshares.org/wallet, web wallet (which is what all web UI are), light wallet (software wallet, downloadable client has it directly in file name), and generally wallet is "A cryptocurrency wallet is a secure digital wallet used to store, send, and receive digital currency". generally, wallet is "where your money is".

I have 50+ crypto and they have all generally referred to wallet as software and location in UI where you see your balances: most common wallet design: https://i.imgur.com/bY8j4if.jpg or e.g. steemit web wallet literally has a tab called wallet for balances. openledger.io (most used ui?) under simple mode writes out "wallet" at the top too.

the only phrase that has the least business of having the word "wallet" in the name is "wallet-model"

wallet model is extra confusing because people who are trying to get a wallet pick it because it's called wallet. account model users are confused how do they withdraw money to their wallet from the dex. bts predates a lot of crypto, but should be consistent with terminology to make it easier to understand.

The main difference is in backup requirements (file) and having multiple accounts - hence I think "wallet model" should be renamed - "file model" or "multi-account file model" with the first option hidden unless advanced user. Someone restoring from a file will quite obviously figure out file one is the one to use.

@wmbutler
Copy link
Contributor Author

Regarding the wallet naming, I think we are stuck with it. I think if a user picks an account model and then sees their wallet balance, it's going to get very difficult to support them, whereas, their portfolio can be referred to as such whether they choose the wallet model or the account model.

@wmbutler wmbutler changed the title [10] Tables Rewrite [12] Tables Rewrite Sep 19, 2017
@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 19, 2017

Markets

  • Maybe we need the logos here too?

screen shot 2017-09-19 at 2 29 04 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 19, 2017

Colors:

Top Left Holdings: 27384B
Top Bar: 1A242F
Dimmed Header Text: 606060
Table Header: 1A242F
Table Cells: 27384B
Bright Text: 000000
Green: 7ED321
Table Cell Border: 323131

@wmbutler
Copy link
Contributor Author

On side bar:

  • Change Overview to Dashboard.
  • Remove Open Orders since it gets incorporated into the Dashboard.

screen shot 2017-09-19 at 11 57 46 am

@wmbutler wmbutler changed the title [12] Tables Rewrite [14] Tables Rewrite Sep 19, 2017
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Sep 19, 2017
@svk31
Copy link
Contributor

svk31 commented Sep 19, 2017

Holdings vs Portfolio is confusing to me, they mean the same thing.

@wmbutler
Copy link
Contributor Author

wmbutler commented Sep 19, 2017

Let's call is Estimated Value. This fits with the recent naming convention changes. I updated the mockups to reflect this.

@wmbutler wmbutler changed the title [14] Tables Rewrite [14] Tables Rewrite - Overview Sep 19, 2017
@wmbutler wmbutler changed the title [14] Tables Rewrite - Overview [14] Tables Rewrite - Dashboard Sep 19, 2017
@tbone-bts
Copy link

I really like the new design of these tables. One thing confuses me, though. What is the purpose of the Markets table? Unless I'm missing something, it really doesn't seem to belong here.

@wmbutler
Copy link
Contributor Author

Well, the problem is.... it doesn't really belong anywhere. Right now it's located above the hierarchy of a chosen account, which, for the majority of our users is kinda silly because they only have 1 account. This means that they have to migrate up in hierarchy to view the market and then choose their account after that. So..... I was thinking, why not just put the market in the dashboard? It's still available to all accounts but it's not in the awkward spot it's in now.

@svk31
Copy link
Contributor

svk31 commented Sep 20, 2017

The table layout of activity is very problematic due to the amount of different transaction types (~40). Trying to fit them all in a table will require a lot of columns, making it confusing imo. It also does not handle proposed transactions very well, I'll see if I can find an example of how that looks atm.

Due to the amount of columns its also very bad for smaller screens and mobile, that's a general concern of tables.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • Font consistency. Remove the narrow font from the TH

screen shot 2017-10-04 at 5 51 37 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • Add price column to Portfolio. Use whatever number you use to derive the value column. (i.e. Qty * Price = Value)
  • Can we change "Unknown value" to "NA" for brevity throughout. Otherwise maybe "--"? I really like -- better.

screen shot 2017-10-04 at 7 47 35 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • odd gap in my portfolio between bitUSD and open.BTC. Not sure what causes this.

screen shot 2017-10-04 at 7 56 21 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • Excessive right padding in this dropdown, Activity tab
  • Reminder: move this to the TH replacing OPERATION text

screen shot 2017-10-05 at 2 42 15 am

@svk31
Copy link
Contributor

svk31 commented Oct 5, 2017

No idea what you mean by narrow fonts in the header.

I used to have n/a for unknown prices, but nobody understood what that meant so I changed it..

The gap in the portfolio is between assets you actually have and the default list of assets that are shown so you can easily buy or trade them, they're shortcuts basically.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • The Narrow font is Roboto Condensed. Let's just use Roboto.
  • Can we try -- ? I'll defend the decision.
  • Would you be ok removing the gap? From what I can tell it doesn't really serve any functional purpose and it throws off the consistency of the row height.

I know it feels like I'm being really picky at this point, but it's my hope that we can set as many standards now as possible on these tables. Please increase the hours on this items to reflect your time worked.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • We need a price on the Portfolio page. Qty * Price = Value. If we have a value and a qty, it's really important that we include the price. This isn't really an optional field when a user is looking at their total assets.

screen shot 2017-10-05 at 9 51 53 am

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 5, 2017

  • We have the call price listed but not the price on the margin screen. I agree we have the ratio, but it makes sense to include the price as well for the user. This would also allow the user to validate the ratio value.

screen shot 2017-10-05 at 10 00 47 am

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 6, 2017

  • The sort order on the open orders listing appears arbitrary. I think we need to pick something that will remain static if the user chooses to toggle the price. Either the order placement date or expiration date would suffice. I still feel that a visible date field is important here but at a minimum, we should let the default sort order be by date. I don't know whether it should be ascending or descending. I'd imagine this will eventually be a user selectable value.

open_order_sort

@svk31
Copy link
Contributor

svk31 commented Oct 6, 2017

The sort order is by price, which is the only sorting that makes sense.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 6, 2017

Hrmmm, open orders being sorted on price? I would think grouped by market and then date makes more sense. The sort order should not change when switching the pricing pair. I hope you take some time to reconsider your opinion here.

@svk31
Copy link
Contributor

svk31 commented Oct 6, 2017

By markets first, then price.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 6, 2017

My fear is that when someone inverts the price, they will lose whatever row they might have been on and may end up canceling the wrong order.

@svk31
Copy link
Contributor

svk31 commented Oct 6, 2017

The market direction is persistent and consistent with your selection everywhere else, so I don't see why anyone would ever switch that direction more than once anyway.

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 6, 2017

  • Total summary should be aligned with Value column

screen shot 2017-10-06 at 8 14 05 am

@svk31
Copy link
Contributor

svk31 commented Oct 6, 2017

Sorting by price makes it look similar to a vertical orderbook, which at least to me makes a lot of sense..

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 8, 2017

  • Anytime displayed currency is the same as the bitasset, we should display a 1 for the price.

screen shot 2017-10-08 at 12 46 05 pm

@wmbutler
Copy link
Contributor Author

wmbutler commented Oct 8, 2017

  • If user has any potential margin call issues, match color of dollar value in header to most vulnerable position.

Current

screen shot 2017-10-08 at 1 48 13 pm

Expected

screen shot 2017-10-08 at 2 04 04 pm

@svk31
Copy link
Contributor

svk31 commented Oct 10, 2017

I think this is about ready now, it's also taken a lot more time than the original estimate, at least 3 full days or 24 hours.

@wmbutler
Copy link
Contributor Author

I figured!

@wmbutler wmbutler changed the title [14] Tables Rewrite - Dashboard [24] Tables Rewrite - Dashboard Oct 10, 2017
@tbone-bts
Copy link

In a portfolio view, it makes the most sense for your largest positions to be at the top, smallest at the bottom. So sorting descending by Value (not by Price) would really be best here.

Sorting by price makes it look similar to a vertical orderbook, which at least to me makes a lot of sense..

@wmbutler
Copy link
Contributor Author

@tbone-bts we are cutting off the features for now. This falls under sort order. Open a separate issue for allowing sortby. Thanks.

@tbone-bts
Copy link

I agree that allowing sortby is a different issue. But I was talking about the default sort order. @svk suggested default sort order should be by Price bc it's similar to order book...and I was pointing out that in a portfolio it should be sorted descending by Value of the holding.

@svk31
Copy link
Contributor

svk31 commented Oct 10, 2017

We were talking about open orders, not the portfolio.

I agree it makes sense to sort the portfolio by value of the holdings, I'll have a look to see how difficult it would be to implement.

@tbone-bts
Copy link

Ah ok, your comment was directly after a post with an image of the Portfolio table. Threw me off. But thanks for clarifying!

@svk31
Copy link
Contributor

svk31 commented Oct 11, 2017

Merged

@svk31 svk31 closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

7 participants