Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.25] Change Name of Program to "BitShares" #418

Closed
landry314 opened this issue Sep 17, 2017 · 11 comments
Closed

[0.25] Change Name of Program to "BitShares" #418

landry314 opened this issue Sep 17, 2017 · 11 comments
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@landry314
Copy link

landry314 commented Sep 17, 2017

The program is called the "Light Wallet" and inside of it there are "Wallets" you can create and control or you can use the Account Model and not use a wallet.

It is confusing to have the same name for two different things. Is the wallet the program or the things that hold my accounts inside the program? This confuses new users.

Since the word wallet is used to refer to the account-holding object within the program much more than the program itself and since the program actually does much more than just function as a wallet, the easiest and clearest thing to do is simply rename the program.

"BitShares Light Client" is ok but most users have no idea why is it called "Light" anyway. What about these ideas:

  • BitShares Client
  • BitShares Browser
  • BitShares (like it used to be called in the 0.9.3c days)
  • BitShares Interface

I think plain old "BitShares" it the best but I understand using the same name as the blockchain or the BTS asset might confuse something. "BitShares Client" fixes that but an average user doesn't necessarily understand the computer jargon "client/server" so they might think it is for the clients of some company, I don't know.

Also, should we capitalize the S in shares? I'm not sure.

Finally, I do also understand we want to differentiate the web interface from the program. That might be why the word light was used in the first place. I don't know.

Plain old BitShares is my vote. Simple, Elegant, Clear. Haha.

@landry314
Copy link
Author

This has been discussed but not had an issue opened.

#378 (comment)
#301 (comment)

@landry314 landry314 changed the title Change Name of Program to "Light Client" Change Name of Program to "BitShares" or "BitShares Client" Sep 17, 2017
@wmbutler
Copy link
Contributor

I like just Bitshares.

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Sep 17, 2017
@btswolf
Copy link

btswolf commented Sep 18, 2017

bitshares_client

@landry314
Copy link
Author

@btswolf, Everywhere I look online the S is capital in BitShares. I guess that is the way we should write it.

@wmbutler wmbutler added this to the 171001 milestone Sep 19, 2017
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Sep 19, 2017
@wmbutler wmbutler changed the title Change Name of Program to "BitShares" or "BitShares Client" [1] Change Name of Program to "BitShares" or "BitShares Client" Sep 19, 2017
@wmbutler
Copy link
Contributor

@svk31 Probably does make sense to just call all the binaries just "Bitshares"

@ariesjia
Copy link
Contributor

Can i take this feature ?

@wmbutler
Copy link
Contributor

@ariesjia This should probably be claimed by @svk31 or @calvinfroedge because they have worked with the binary builds.

@wmbutler wmbutler changed the title [1] Change Name of Program to "BitShares" or "BitShares Client" [1] Change Name of Program to "BitShares" Sep 19, 2017
@svk31
Copy link
Contributor

svk31 commented Sep 20, 2017

Personally I prefer Bitshares with lowercase s, but we did a round on this a while back and the community decision was to use BitShares with a capitalised S so that's what the GUI tries to use everywhere.

One problem with renaming the binaries is that it may create a new storage domain, meaning that old wallets will not be available from the new binaries.

@landry314
Copy link
Author

On Mac OS, the name was just changed from "BitShares2-light" to "BitShares Light Wallet" and nothing weird happened. Maybe because the support folder at _ Library -> Application Support -> BitShares2-light _ retained the same name.

@svk31
Copy link
Contributor

svk31 commented Sep 20, 2017

Right, as long as the package name defined here: https://github.com/bitshares/bitshares-ui/blob/staging/package.json#L2 remains the same, the storage domain will be the same.

The product name (Bitshares Light Wallet) is defined here: https://github.com/bitshares/bitshares-ui/blob/staging/package.json#L76 and can safely be changed.

@wmbutler
Copy link
Contributor

I think all that really matters is the visual here. We have a lot of extra words that aren't relevant anymore:

  • Light used to be relevant to distinguish it from the full client
  • Wallet used to be relevant before we added the account model

@svk31 svk31 changed the title [1] Change Name of Program to "BitShares" [0.25] Change Name of Program to "BitShares" Sep 21, 2017
@svk31 svk31 closed this as completed in fa07b40 Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

5 participants