Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.25] Change equivalent value to Estimated Value #411

Closed
knifewine opened this issue Sep 15, 2017 · 3 comments
Closed

[.25] Change equivalent value to Estimated Value #411

knifewine opened this issue Sep 15, 2017 · 3 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@knifewine
Copy link

On the account page, there's a column for "Equivalent Value".

When the asset value is already displayed in that denomination, the Equivalent Value column should probably just show the same value, or be blank. E.g. when the account has 0.57 USD, it's odd to display the Equivalent Value as "1 USD".

To repro:
Set account to display in USD.
Make sure account holds a non-integer amount of USD (e.g. 0.57)
Look at the Accounts screen.

issue

@wmbutler
Copy link
Contributor

wmbutler commented Sep 15, 2017

I'm guessing we are doing some rounding here to provide a simpler overview. The label could definitely be better. Maybe change the label to approximate value.

@wmbutler
Copy link
Contributor

See #378 Tables Rewrite as well regarding this label display.

@landry314
Copy link

landry314 commented Sep 16, 2017

But the word "equivalent" is good when it is converting from another unit but not exactly a good word when it is the same unit.

Maybe "Estimated Value"? That kind of includes both ideas.

@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Sep 17, 2017
@wmbutler wmbutler changed the title don't show equivalent value for same asset denomination [.1] Change equivalent value to Estimated Value Sep 17, 2017
@wmbutler wmbutler added this to the 171001 milestone Sep 17, 2017
@wmbutler wmbutler changed the title [.1] Change equivalent value to Estimated Value [.25] Change equivalent value to Estimated Value Sep 21, 2017
@svk31 svk31 self-assigned this Sep 22, 2017
@svk31 svk31 closed this as completed in c3be6c8 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

4 participants