Safer way to handle secret information of cli_wallet #1171 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2018
3 tasks
pmconrad
suggested changes
Apr 12, 2019
src/rpc/cli.cpp
Outdated
| @@ -250,6 +249,12 @@ void cli::getline( const fc::string& prompt, fc::string& line) | |||
| FC_THROW_EXCEPTION( fc::eof_exception, "" ); | |||
| line = line_read; | |||
| // we don't need here to add line in editline's history, cause it will be doubled | |||
| if (cli_check_secret(line_read)) { | |||
| el_no_echo = 1; | |||
| line_read = readline("Enter password: "); | |||
There was a problem hiding this comment.
Must free(line_read) before re-using it
src/rpc/cli.cpp
Outdated
| el_no_echo = 1; | ||
| line_read = readline("Enter password: "); | ||
| el_no_echo = 0; | ||
| line = line + ' ' + line_read; |
|
@cogutvalera do you have time to continue the work on this? |
Closed
yes sure |
@cogutvalera any estimate when you do this? |
|
I will try to do it till the end of this week, was unplanned busy |
…for nullptr read_line before using it
cogutvalera
force-pushed
the
issue_1171_hiding_secret
branch
from
60bb2ee
to
22d9ce2
Compare
cogutvalera
force-pushed
the
issue_1171_hiding_secret
branch
from
22d9ce2
to
7208054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing bitshares/bitshares-core#1171 issue
Safer way to handle secret information of cli_wallet
Depends on already merged PRs: