-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer way to handle unlock command of cli_wallet #1171
Comments
Just a note: please keep the |
Agree @abitmore . We need to add a new call with no arguments Problem is it seems there is no easy way of making it work in linux/windows/macos with the same code. In windows it needs to be done different, it seems an We can start building a version only for linux and decide what to do in windows later. Other suggestions are welcome. |
I want to claim this issue |
Thanks ! |
@cogutvalera please note @oxarbitrage comment above about implementing May I suggest we start with 2 hours for research and first test case, then discuss estimation for a Linux implementation? |
ok sure ! Thank you very much ! |
@ryanRfox after my researches I found that the best cross-platform solution without impacting existing JSON-RPC API implementation as @abitmore mentioned, is not to show Key points:
@ryanRfox my estimation for this issue is approximately 10 hours. Thanks ! |
Interesting idea. If you choose that route, please make it somehow configurable (for the calling application) when input is blanked out. That would make it possible to use the same mechanism not only for Glancing over the editline code my impression is that your approach will be tricky to get right, to say the least. Can you give us some high-level pseudocode of what your plan is? |
@pmconrad yes for sure I want to make it configurable for any other After my researches and some debugging inside High-level pseudo-code:
What should I do:
Thanks ! |
AFAIK editline doesn't work in Windows. |
@abitmore yes you're absolutely right about https://github.com/troglobit/editline
For Windows I want to make change on the fly too (the same idea), but after finishing with @ryanRfox my current estimation of 10 hours doesn't include Windows solution. Let's discuss about Windows estimation after Linux/MacOS solution will be implemented as @oxarbitrage and you told earlier. Thanks ! |
@ryanRfox extend please my estimation from 10 hours to 15 hours approximately for this issue, cause I'm fighting with Thanks ! |
there are 3 PRs (core, fc, editline):
What about PR for Thank you very much ! |
Editline is a project by troglobit. They can choose to accept your change or not. The joy of open source is that you can fork their project and change what you want. If you want Bitshares to use your code instead of troglobit, I see two options:
If we think there will be only minor changes to editline, I would say option 1 is fine. If we think there will be many, and many contributors, I would say option 2 is better. |
my question is: what way should we choose from 2 options that you told :) |
We should not link to versions in individual developer repos. If we want your solution and troglobit doesn't approve your PR, we will have to fork it in the bitshares project. |
Safer way to handle unlock command of cli_wallet #1171
Implemented with PR #1382. Docs are needed for closing this. |
Also do we need windows (without |
should I estimate windows (without |
IMHO don't waste time on Windows so far. |
ok |
Is the windows behaviour the same for If so, we should close this issue and open a new one for windows fix. |
Note: docs are needed for closing this issue (including readme, wiki, tutorials, how.bitshares.works and etc).
|
Ping @cedar-book - no rush |
Okay! Thank you. |
Hi @pmconrad, I updated this section 3.Unlock the Cli_Wallet to show how it works. |
@cedar-book as mentioned in Telegram and in above comment (#1171 (comment)), please update tutorial about
By the way, the current tutorial is a bit confusing, since there are 2 |
Update: https://dev.bitshares.works/en/master/development/apps/cli_wallet.html#unlock-the-cli-wallet has been updated. We may still want to update README of this repository, the CLI cook book, and etc. |
Created new issue for the docs: #1886. Closing this one in order to close the 3.2 project and milestone. |
User Story
The
unlock
command should not echo back the wallet password for safety concerns.Ideally, this command should be handled interactively, like
completely without showing the password on the console.
Additional Context (optional)
Maybe all commands related to
unencryptedWIF should also apply to this.CORE TEAM TASK LIST
The text was updated successfully, but these errors were encountered: