Safer way to handle unlock command of cli_wallet #1171 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after merging this #82 PR and without merging PR bitshares/bitshares-core#1382 there will be SEGFAULT when starting |
cogutvalera
force-pushed
the
issue_1171
branch
from
74409f6
to
157273f
Compare
pmconrad
reviewed
Oct 30, 2018
src/rpc/cli.cpp
Outdated
| @@ -210,7 +210,7 @@ static int cli_completion(char *token, char ***array) | |||
| */ | |||
| static int cli_check_secret(const char *source) | |||
| { | |||
| if (boost::regex_match(source, cli_regex_secret())) | |||
| if (nullptr != cli_regex_secret().expression() && boost::regex_match(source, cli_regex_secret())) | |||
There was a problem hiding this comment.
|
Thanks ! |
cogutvalera
added a commit
to cogutvalera/bitshares-fc
that referenced
this pull request
Nov 18, 2018
While issue bitshares/bitshares-core#1171 is hold on and open we need to revert these both PRs to avoid compilation errors
This was referenced Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if exists regex expression, this PR is for bitshares/bitshares-core#1171 issue