-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix [seed.role] #1340
Comments
Hi @samseaver, there doesn't appear to be enough information in this new prefix request to make a follow-up. It appears that the example you gave is an EC number. This already has a prefix It might be helpful to describe the semantic space itself instead of the resource that it comes from. What is a "role" in SEED? What kinds of things appear in this semantic space? Is there something other than enzymes, or is it just a duplicate of EC? You might also want to take a look at existing SEED prefixes: |
Hi, so, this is basically an ontology that is controlled by the organization known as SEED, there's not much other than their own publications and web-pages that describes how they curate their ontology, the paper I linked pretty much describes it. The "subsystem" is a collection of molecular roles, and the molecular roles describe the function of one or more protein in microbes and plants. It is in fact an ontology much like many of the other biological ontologies that are registered in bioregistry.io, but its parent organization does the curation. It then follows that the text of the curation, though they don't use identifiers, is what they decide it should be, as in essence, it can differentiate from what other ontologies use. The use of an EC number or in the case of transporters, a TC number, etc. links the descriptive text of the molecular role to another ontology of course, but doesn't necessarily mean that the role itself is exactly what you would see elsewhere. Does this help? |
Hello, is there any update to this? |
Hi @samseaver, I think to properly address this, we would want to carefully review of all the existing prefixes related to SEED and your contributions in that context, and come up with a comprehensive solution for its representation. Unless someone else volunteers to do this, I think @nalikapalayoor could take this on and dig into the details to understand what is going on and how to best organize all the metadata surrounding SEED. |
Hi, yes I am happy to look into this! |
Hello, @nalikapalayoor and I have looked into this issue in more detail, here is a summary of our findings and what we think the next steps should be:
We can make changes accordingly, let us know if there is anything else we missed! |
Hello, this is great! I appreciate that you two took the time to look into this, and it's very helpful. We're glad that we're on the same page with the system of dedicated prefixes, and I think that covers it. Thank you! |
I'm not sure I agree that identifiers like
I'm not quite sure I understand this, does it mean that there are other kinds of things that appear as a SEED role? Like from the Transporter Classification Database (which is what I guess you mean by TC)? Can you give some more examples of things that are SEED roles to cover all different varieties? In situations where the semantic space is reused in a trivial way, e.g., like how record for the SABIO-RK ( However, here, it's not clear if it's fair to say this is a new semantic space, or just an implementation detail of SEED in representing an existing semantic space. Since the job of Bioregistry is to represent semantic spaces, and not projects/tools/databases, this is where my concerns come from. Therefore, I would like some time to investigate further if there are any examples of other prefixes that are minted this way. I think it's probably the case that we haven't done this before (intentionally) Further, I re-read the contribution guidelines and found that I had not included any guidance on what constitutes a semantic space itself. I think that such a section would necessarily need to draw from W3C guidelines/specifications on CURIEs, the Identifiers for the 21st century: How to design, provision, and reuse persistent identifiers to maximize utility and impact of life science data, and maybe some other sources. I would like to make clear some guidance to help in future submissions Given that I haven't given very positive feedback after you all put some thought and effort into this, I'll pose three alternatives for consideration:
|
Only some roles are EC-code related. There are many roles with no corresponding EC-code, e.g.,
So I still maintain that having a dedicated prefix for |
Okay, so I don't think any of my suggestions are actionable. Let's just add some |
I'm late responding as we had a holiday weekend, but thanks again for the feedback, we appreciate that it isn't a straight-forward situation with semantic spaces. |
I just pushed example_extras with non-EC-code examples which I think resolves everything we discussed so far |
Closes #1340 --------- Co-authored-by: samseaver <[email protected]> Co-authored-by: Ben Gyori <[email protected]>
Prefix
seed.role
Name
The SEED
Homepage
https://theseed.org/
Source Code Repository
https://github.com/orgs/TheSEED
Description
With the growing number of available genomes, the need for an environment to support effective comparative analysis increases. The original SEED Project was started in 2003 by the Fellowship for Interpretation of Genomes (FIG) as a largely unfunded open source effort. Argonne National Laboratory and the University of Chicago joined the project, and now much of the activity occurs at those two institutions (as well as the University of Illinois at Urbana-Champaign, Hope college, San Diego State University, the Burnham Institute and a number of other institutions). The cooperative effort focuses on the development of the comparative genomics environment called the SEED and, more importantly, on the development of curated genomic data.
License
MIT
Publications
doi:10.1093/nar/gki866
Example Local Unique Identifier
Histidinol dehydrogenase (EC 1.1.1.23)
Regular Expression Pattern for Local Unique Identifier
No response
URI Format String
No response
Wikidata Property
No response
Contributor Name
Sam Seaver
Contributor GitHub
samseaver
Contributor ORCiD
0000-0002-7674-5194
Contributor Email
No response
Contact Name
No response
Contact ORCiD
No response
Contact GitHub
No response
Contact Email
No response
Additional Comments
No response
The text was updated successfully, but these errors were encountered: