Skip to content

feat(migrate): more metadata for rules from html-eslint#9106

Merged
dyc3 merged 1 commit intomainfrom
dyc3/html-rule-source-metadata
Feb 16, 2026
Merged

feat(migrate): more metadata for rules from html-eslint#9106
dyc3 merged 1 commit intomainfrom
dyc3/html-rule-source-metadata

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Feb 16, 2026

Summary

I did a quick scan over the rules in https://html-eslint.org and updated our rule sources.

Test Plan

CI should be green

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: c8d6bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-HTML Language: HTML and super languages labels Feb 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

This PR adds html-eslint rule source metadata to several existing HTML accessibility linter rules and expands the unsupported rules migration list with HTML eslint entries. The changes connect Biome's HTML linter rules to their corresponding html-eslint rule identifiers, enabling better rule provenance tracking during migration from other linters.

Possibly related PRs

Suggested labels

A-Linter, A-CLI, L-HTML

Suggested reviewers

  • ematipico
  • Netail
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding HTML ESLint rule source metadata across multiple lint rules and the unsupported rules list.
Description check ✅ Passed The description explains the motivation (scanning html-eslint.org rules) and relates to the changeset, though it could be more detailed about the specific changes made.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dyc3/html-rule-source-metadata

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2026

Merging this PR will degrade performance by 7.68%

❌ 2 regressed benchmarks
✅ 1 untouched benchmark
🆕 1 new benchmark
⏩ 152 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 html_analyzer[index_1033418810622582172.html] N/A 418.9 µs N/A
index_1033418810622582172.html[cached] 102 µs 110 µs -7.31%
index_1033418810622582172.html[uncached] 118.2 µs 128 µs -7.68%

Comparing dyc3/html-rule-source-metadata (c8d6bbd) with main (0c0fb6f)2

Open in CodSpeed

Footnotes

  1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (fc9850c) during the generation of this report, so 0c0fb6f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@dyc3 dyc3 merged commit f4b7296 into main Feb 16, 2026
17 of 18 checks passed
@dyc3 dyc3 deleted the dyc3/html-rule-source-metadata branch February 16, 2026 19:12
@github-actions github-actions bot mentioned this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Linter Area: linter L-HTML Language: HTML and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant