feat(html/noPositiveTabindex): port noPositiveTabindex rule to HTML by tt-a1i · Pull Request #8501 · biomejs/biome

tt-a1i · 2025-12-18T14:21:20Z

Summary

Contributes to #8155

Ports the existing JSX noPositiveTabindex rule to HTML. This rule prevents the usage of positive integers on the tabindex attribute, which can disrupt natural keyboard navigation order.

Changes:

Added noPositiveTabindex rule for HTML in crates/biome_html_analyze/src/lint/a11y/
Added test cases for invalid and valid HTML
Includes unsafe fix to remove the tabindex attribute

Test plan

Added invalid.html with positive tabindex values (1, 5, 2, 10, 99)
Added valid.html with valid tabindex values (0, -1)
All tests pass

AI Assistance Disclosure

I used Codex to review the changes, sanity-check the implementation against existing patterns, and help spot potential edge cases.

Port the existing JSX noPositiveTabindex rule to HTML. The rule prevents the usage of positive integers on the tabindex attribute, which can disrupt natural keyboard navigation order. Contributes to biomejs#8155

changeset-bot · 2025-12-18T14:21:25Z

🦋 Changeset detected

Latest commit: c419b89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2025-12-18T14:28:13Z

CodSpeed Performance Report

Merging #8501 will not alter performance

_{Comparing tt-a1i:feat/html-no-positive-tabindex-next (c419b89) with next (c61892d)}

Summary

✅ 1 untouched
⏩ 154 skipped¹

154 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai · 2025-12-18T14:35:23Z

Walkthrough

This PR adds an HTML accessibility lint rule noPositiveTabindex that flags positive tabindex values, registers the rule in the A11y lint group, and provides diagnostics plus an automatic fix (removes the offending attribute). It also adds tests for valid and invalid cases and a changeset declaring a minor release.

Possibly related PRs

feat(lint/html): implement useAriaPropsForRole for html #8381: Adds a new a11y HTML lint rule and updates crates/biome_html_analyze/src/lint/a11y.rs to register the rule.
feat(lint/html): add noAccessKey #8165: Adds an HTML accessibility lint rule with the same module registration pattern and test structure.
fix(noPositiveTabindex): suppression action #7476: Touches the same noPositiveTabindex rule surface (JS/JSX implementation) fixing suppression/text-range behaviour.

Suggested reviewers

ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarises the main change: porting the noPositiveTabindex rule from JSX to HTML, which matches the changeset content.
Description check	✅ Passed	The description is well-related to the changeset, detailing the rule's purpose, implementation location, test cases, and approach — all directly corresponding to the changes made.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28aab2a and c419b89.

📒 Files selected for processing (1)

.changeset/html-no-positive-tabindex.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/html-no-positive-tabindex.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: autofix
GitHub Check: Documentation
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: End-to-end tests
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Bench (biome_configuration)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

.changeset/html-no-positive-tabindex.md (1)
5-5: Consider adding a code example.

As per coding guidelines for changesets, rule additions should include a code example to help users understand what the rule detects.
🔎 Suggested enhancement:
-Added [`noPositiveTabindex`](https://biomejs.dev/linter/rules/no-positive-tabindex/) rule for HTML. This rule prevents the usage of positive integers on the `tabindex` attribute, which can disrupt natural keyboard navigation order.
+Added [`noPositiveTabindex`](https://biomejs.dev/linter/rules/no-positive-tabindex/) rule for HTML. This rule prevents the usage of positive integers on the `tabindex` attribute, which can disrupt natural keyboard navigation order.
+
+```html
+<div tabindex="1"></div>
+```
crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs (1)

52-55: Consider reducing visibility.

NoPositiveTabindexState appears to be used only within this module. You could tighten encapsulation with pub(crate) unless there's a convention requiring pub for rule state structs.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c61892d and 28aab2a.

⛔ Files ignored due to path filters (5)

crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
crates/biome_html_analyze/tests/specs/a11y/noPositiveTabindex/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/noPositiveTabindex/valid.html.snap is excluded by !**/*.snap and included by **
packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (5)

.changeset/html-no-positive-tabindex.md (1 hunks)
crates/biome_html_analyze/src/lint/a11y.rs (1 hunks)
crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs (1 hunks)
crates/biome_html_analyze/tests/specs/a11y/noPositiveTabindex/invalid.html (1 hunks)
crates/biome_html_analyze/tests/specs/a11y/noPositiveTabindex/valid.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

crates/**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Update inline rustdoc documentation for rules, assists, and their options when adding new features or changing existing features in Rust crates

Files:

crates/biome_html_analyze/src/lint/a11y.rs
crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs

.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Write changesets that are concise (1-3 sentences), user-focused, use past tense for actions taken and present tense for Biome behavior, include code examples for rules, and end sentences with periods

Files:

.changeset/html-no-positive-tabindex.md

🧠 Learnings (24)