fix(lint): regression of the noUnknownPseudoElement rule#9100
Conversation
🦋 Changeset detectedLatest commit: 08c0eef The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e543fca to
6d4f1af
Compare
WalkthroughAdds a patch changelog entry for a fix addressing issue Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.changeset/tame-pants-pay.md:
- Line 5: Update the changeset sentence to correct grammar and clearly state the
behavior: change "Fixed ... report" to "Fixed ... reports" and use past tense
for the action ("Fixed"). Then explicitly list which selectors are now accepted
by the rule to clarify behavior — reference the rule name noUnknownPseudoElement
and state that CSS module-scoped selectors such as :local(...), :global(...),
and module-generated class selectors (e.g., .foo or .foo___hash) are no longer
flagged; keep the description concise and use present tense when describing
Biome behavior.
Merging this PR will not alter performance
Comparing Footnotes
|
6d4f1af to
08c0eef
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.changeset/tame-pants-pay.md:
- Line 5: Update the changelog entry text in .changeset/tame-pants-pay.md to
hyphenate "pseudo-elements" (change the phrase "pseudo elements" to
"pseudo-elements") in the sentence referencing the noUnknownPseudoElement rule
so the compound term follows standard style; search for the substring
"noUnknownPseudoElement" or the sentence "noUnknownPseudoElement rule no longer
reports false positives for any known pseudo elements" and replace with the
hyphenated form.
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Fixed [#9081](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0. |
There was a problem hiding this comment.
Hyphenate “pseudo-elements”.
It’s the standard compound form.
✏️ Proposed tweak
-Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0.
+Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo-elements in CSS modules. This was a regression introduced in v2.4.0.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Fixed [#9081](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0. | |
| Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo-elements in CSS modules. This was a regression introduced in v2.4.0. |
🧰 Tools
🪛 LanguageTool
[misspelling] ~5-~5: This word is normally spelled with a hyphen.
Context: ...r reports false positives for any known pseudo elements in CSS modules. This was a regression i...
(EN_COMPOUNDS_PSEUDO_ELEMENTS)
🤖 Prompt for AI Agents
In @.changeset/tame-pants-pay.md at line 5, Update the changelog entry text in
.changeset/tame-pants-pay.md to hyphenate "pseudo-elements" (change the phrase
"pseudo elements" to "pseudo-elements") in the sentence referencing the
noUnknownPseudoElement rule so the compound term follows standard style; search
for the substring "noUnknownPseudoElement" or the sentence
"noUnknownPseudoElement rule no longer reports false positives for any known
pseudo elements" and replace with the hyphenated form.
Summary
Fixes #9081
There was a regression that the rule don't accept any pseudo elements anymore except
:globaland:localin CSS modules.Test Plan
Added snapshot tests
Docs
N/A