Skip to content

fix(lint): regression of the noUnknownPseudoElement rule #9100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Feb 16, 2026
Merged

fix(lint): regression of the noUnknownPseudoElement rule #9100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-pants-pay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed [#9081](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0.
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Hyphenate “pseudo-elements”.
It’s the standard compound form.

✏️ Proposed tweak 
-Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0.
+Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo-elements in CSS modules. This was a regression introduced in v2.4.0.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fixed [#9081](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo elements in CSS modules. This was a regression introduced in v2.4.0.
Fixed [`#9081`](https://github.com/biomejs/biome/issues/9081): The `noUnknownPseudoElement` rule no longer reports false positives for any known pseudo-elements in CSS modules. This was a regression introduced in v2.4.0.
🧰 Tools
🪛 LanguageTool

[misspelling] ~5-~5: This word is normally spelled with a hyphen.
Context: ...r reports false positives for any known pseudo elements in CSS modules. This was a regression i...

(EN_COMPOUNDS_PSEUDO_ELEMENTS)

🤖 Prompt for AI Agents 
In @.changeset/tame-pants-pay.md at line 5, Update the changelog entry text in
.changeset/tame-pants-pay.md to hyphenate "pseudo-elements" (change the phrase
"pseudo elements" to "pseudo-elements") in the sentence referencing the
noUnknownPseudoElement rule so the compound term follows standard style; search
for the substring "noUnknownPseudoElement" or the sentence
"noUnknownPseudoElement rule no longer reports false positives for any known
pseudo elements" and replace with the hyphenated form.

7 changes: 2 additions & 5 deletions crates/biome_css_analyze/src/lint/correctness/no_unknown_pseudo_element.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,8 @@ fn should_not_trigger(
let lowercase = pseudo_element_name.to_ascii_lowercase_cow();
let lowercase = &lowercase.as_ref();

if file_source.is_css_modules() {
return ["global", "local"].contains(lowercase);
}

!vender_prefix(pseudo_element_name).is_empty()
(file_source.is_css_modules() && ["global", "local"].contains(lowercase))
|| !vender_prefix(pseudo_element_name).is_empty()
|| is_pseudo_elements(lowercase)
|| should_ignore(pseudo_element_name, options)
}
Expand Down
11 changes: 11 additions & 0 deletions crates/biome_css_analyze/tests/specs/correctness/noUnknownPseudoElement/valid.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/* should not generate diagnostics */

/* CSS modules specific */
:global(.foo),
:local(.foo) {}

/* https://github.com/biomejs/biome/issues/9081 */
* {
&::after,
&::before {}
}
19 changes: 19 additions & 0 deletions ...es/biome_css_analyze/tests/specs/correctness/noUnknownPseudoElement/valid.module.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
source: crates/biome_css_analyze/tests/spec_tests.rs
expression: valid.module.css
---
# Input
```css
/* should not generate diagnostics */

/* CSS modules specific */
:global(.foo),
:local(.foo) {}

/* https://github.com/biomejs/biome/issues/9081 */
* {
&::after,
&::before {}
}

```