Conversation
🦋 Changeset detectedLatest commit: f26b1da The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
A-CLI
ematipico
approved these changes
Feb 14, 2026
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
It's a bit unfortunate we need to resort to a visitor, but I think it's the correct solution with what we have.
The other solution would be to remove the Raw variant for typed diagnostics, but it would require some refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The primary reason for this fix is to the diagnostic locations as outlined in #9057, but other snapshots would indicate that other diagnostics were slightly off as well. I went and checked the diffs for the snapshots that were affected, and this does appear to also fix an off-by-one error with how we were reporting line numbers in embedded snippets.
Changeset included this time because i think it could affect things that have already released, but I haven't bothered to check yet. Can backport the fix if we think it's necessary.
Tbh, I'm not confident that this is the correct fix, but it does fix the issue.
Generated with kimi k2.5, and then i ran out of free quota on opencode so i switched to big pickle.
fixes #9057
Test Plan
added a cli test, snapshots.
Docs