Skip to content

fix(service): include embedded bindings and value reference services when applying suppressions#9059

Merged
dyc3 merged 2 commits intonextfrom
dyc3/fix-bad-suppressions-in-vue
Feb 14, 2026
Merged

fix(service): include embedded bindings and value reference services when applying suppressions#9059
dyc3 merged 2 commits intonextfrom
dyc3/fix-bad-suppressions-in-vue

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Feb 13, 2026

Summary

--supress now acknowledges the embedded bindings and embedded value references document services

generated by kimi k2.5

No changeset since this affects features that have not been released.

fixes #9058

Test Plan

added a snapshot test

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

⚠️ No Changeset found

Latest commit: 7828433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-LSP Area: language server protocol labels Feb 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

This PR adds a test ensuring suppression comments are not emitted for imports used inside Vue templates and updates the JavaScript file handler to set per-iteration embedded bindings and embedded value references on JsAnalyzerServices before analysis. No public API signatures were changed beyond a test import addition.

Possibly related PRs

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

  • arendjr
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (74 files):

⚔️ .claude/skills/README.md (content)
⚔️ .claude/skills/testing-codegen/SKILL.md (content)
⚔️ AGENTS.md (content)
⚔️ crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs (content)
⚔️ crates/biome_cli/tests/cases/handle_svelte_files.rs (content)
⚔️ crates/biome_cli/tests/cases/handle_vue_files.rs (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/full_support.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/full_support.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/full_support_ts.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support_jsx.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support_ts.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support_tsx.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_cases_html/should_apply_fixes_to_embedded_languages.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_commands_lint/lint_only_group_skip_rule.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_commands_lint/linter_shows_the_default_severity_of_rule_on.snap (content)
⚔️ crates/biome_cli/tests/snapshots/main_configuration/incorrect_rule_name.snap (content)
⚔️ crates/biome_configuration/src/analyzer/linter/rules.rs (content)
⚔️ crates/biome_configuration/src/generated/domain_selector.rs (content)
⚔️ crates/biome_diagnostics_categories/src/categories.rs (content)
⚔️ crates/biome_html_analyze/src/lint/a11y/no_redundant_alt.rs (content)
⚔️ crates/biome_html_analyze/src/lint/a11y/no_svg_without_title.rs (content)
⚔️ crates/biome_html_syntax/src/lib.rs (content)
⚔️ crates/biome_js_analyze/src/lint/a11y/no_svg_without_title.rs (content)
⚔️ crates/biome_js_analyze/src/lint/nursery/no_shadow.rs (content)
⚔️ crates/biome_js_analyze/src/lint/nursery/use_explicit_type.rs (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-01.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-02.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-03.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-04.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-05.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-06.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-07.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-08.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-10.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-11.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-12.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-13.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-14.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-15.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-16.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-17.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-18.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-19.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-20.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-21.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-22.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-23.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-24.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-25.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-26.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-27.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-28.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-29.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-30.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-31.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/eslint/invalid-32.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/invalid.js.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-01.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-02.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-03.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-04.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-05.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-06.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-07.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/noShadow/typescript-eslint/invalid-08.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/useExplicitType/invalid.ts.snap (content)
⚔️ crates/biome_js_analyze/tests/specs/nursery/useExplicitType/invalidArguments.ts.snap (content)
⚔️ crates/biome_service/src/file_handlers/html.rs (content)
⚔️ crates/biome_service/src/file_handlers/javascript.rs (content)
⚔️ crates/biome_service/src/settings.tests.rs (content)
⚔️ packages/@biomejs/backend-jsonrpc/src/workspace.ts (content)
⚔️ packages/@biomejs/biome/configuration_schema.json (content)
⚔️ xtask/rules_check/src/lib.rs (content)

These conflicts must be resolved before merging into next.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: including embedded bindings and value reference services in the suppression code path, which directly addresses the linked issue about false positive suppressions.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (fixing false positives in --suppress), mentioning the linked issue (#9058), and noting the test added.
Linked Issues check ✅ Passed The code changes directly address issue #9058 by ensuring embedded bindings and value references are included in the suppress code path, preventing false positive suppression comments.
Out of Scope Changes check ✅ Passed All changes are in-scope: the JavaScript handler fix targets the root cause, and the test validates the specific Vue template scenario from the linked issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dyc3/fix-bad-suppressions-in-vue
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch dyc3/fix-bad-suppressions-in-vue
  • Create stacked PR with resolved conflicts
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3 dyc3 force-pushed the dyc3/fix-bad-suppressions-in-vue branch from bf0733c to 8a0bfa4 Compare February 14, 2026 15:00
@github-actions github-actions bot removed the A-LSP Area: language server protocol label Feb 14, 2026
@dyc3 dyc3 merged commit 4804acf into next Feb 14, 2026
11 checks passed
@dyc3 dyc3 deleted the dyc3/fix-bad-suppressions-in-vue branch February 14, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Project Area: project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants