Skip to content

fix(js_analyze): typo in noPositiveTabindex's action suggestion#9009

Merged
Netail merged 1 commit intobiomejs:mainfrom
Netail:fix/noPositiveTabindex-typo
Feb 9, 2026
Merged

fix(js_analyze): typo in noPositiveTabindex's action suggestion#9009
Netail merged 1 commit intobiomejs:mainfrom
Netail:fix/noPositiveTabindex-typo

Conversation

@Netail
Copy link
Member

@Netail Netail commented Feb 9, 2026

Summary

Fix typo (tableIndex -> tabIndex) in noPositiveTabindex's action text

Test Plan

Unit tests

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

🦋 Changeset detected

Latest commit: da6d163

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Feb 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

This PR corrects a typo in the noPositiveTabindex rule's diagnostic message. The quick fix text previously referenced "tableIndex" (incorrect) and now references "tabIndex" (correct). A corresponding changeset entry is added to document this patch release for @biomejs/biome.

Possibly related PRs

Suggested labels

A-Linter, L-JavaScript, A-Diagnostic

Suggested reviewers

  • ematipico
  • dyc3
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the typo being fixed (tableIndex → tabIndex) and mentions the affected rule.
Title check ✅ Passed The title accurately describes the main change: fixing a typo in the noPositiveTabindex rule's action suggestion text (tableIndex → tabIndex).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail changed the title fix(js_analyze): typo fix(js_analyze): typo in noPositiveTabindex's quick action Feb 9, 2026
@Netail Netail changed the title fix(js_analyze): typo in noPositiveTabindex's quick action fix(js_analyze): typo in noPositiveTabindex's action suggestion Feb 9, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 9, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks1


Comparing Netail:fix/noPositiveTabindex-typo (da6d163) with main (9d1ae81)2

Open in CodSpeed

Footnotes

  1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (6cde25c) during the generation of this report, so 9d1ae81 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Netail Netail merged commit 7d229c7 into biomejs:main Feb 9, 2026
22 checks passed
@Netail Netail deleted the fix/noPositiveTabindex-typo branch February 9, 2026 14:45
@github-actions github-actions bot mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants