Skip to content

fix(js_analyze): typo in noPositiveTabindex's action suggestion #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Netail merged 1 commit into from
Feb 9, 2026
Merged

fix(js_analyze): typo in noPositiveTabindex's action suggestion #9009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-pens-prove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed typo in [noPositiveTabindex](https://biomejs.dev/linter/rules/no-positive-tabindex/)'s quick fix text.
2 changes: 1 addition & 1 deletion crates/biome_js_analyze/src/lint/a11y/no_positive_tabindex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ impl Rule for NoPositiveTabindex {
Some(JsRuleAction::new(
ctx.metadata().action_category(ctx.category(), ctx.group()),
ctx.metadata().applicability(),
markup! { "Replace the "<Emphasis>"tableIndex"</Emphasis>" prop value with 0." }
markup! { "Replace the "<Emphasis>"tabIndex"</Emphasis>" prop value with 0." }
.to_owned(),
mutation,
))
Expand Down
19 changes: 9 additions & 10 deletions crates/biome_js_analyze/tests/specs/a11y/noPositiveTabindex/invalid.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: invalid.jsx
snapshot_kind: text
---
# Input
```jsx
Expand Down Expand Up @@ -36,7 +35,7 @@ invalid.jsx:2:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

1 1 │ <>
2 │ - → <div·tabIndex={1}·/>
Expand All @@ -63,7 +62,7 @@ invalid.jsx:3:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

1 1 │ <>
2 2 │ <div tabIndex={1} />
Expand Down Expand Up @@ -91,7 +90,7 @@ invalid.jsx:4:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

2 2 │ <div tabIndex={1} />
3 3 │ <div tabIndex={"1"} />
Expand Down Expand Up @@ -119,7 +118,7 @@ invalid.jsx:5:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

3 3 │ <div tabIndex={"1"} />
4 4 │ <div tabIndex={'5'} />
Expand Down Expand Up @@ -147,7 +146,7 @@ invalid.jsx:6:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

4 4 │ <div tabIndex={'5'} />
5 5 │ <div tabIndex="1" />
Expand Down Expand Up @@ -175,7 +174,7 @@ invalid.jsx:7:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

5 5 │ <div tabIndex="1" />
6 6 │ <div tabIndex={1}>foo</div>
Expand Down Expand Up @@ -203,7 +202,7 @@ invalid.jsx:8:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

6 6 │ <div tabIndex={1}>foo</div>
7 7 │ <div tabIndex={"1"}>foo</div>
Expand Down Expand Up @@ -231,7 +230,7 @@ invalid.jsx:9:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

7 7 │ <div tabIndex={"1"}>foo</div>
8 8 │ <div tabIndex={'5'}>foo</div>
Expand Down Expand Up @@ -259,7 +258,7 @@ invalid.jsx:11:16 lint/a11y/noPositiveTabindex FIXABLE ━━━━━━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

9 9 │ <div tabIndex={+5}>foo</div>
10 10 │ <div tabIndex={+0o5}>foo</div>
Expand Down
7 changes: 3 additions & 4 deletions ...es/biome_js_analyze/tests/specs/a11y/noPositiveTabindex/reactCreateElementInvalid.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: reactCreateElementInvalid.js
snapshot_kind: text
---
# Input
```js
Expand All @@ -27,7 +26,7 @@ reactCreateElementInvalid.js:1:40 lint/a11y/noPositiveTabindex FIXABLE ━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

1 │ - React.createElement("div",·{·tabIndex:·'1'·})
1 │ + React.createElement("div",·{·tabIndex:·"0"·})
Expand All @@ -52,7 +51,7 @@ reactCreateElementInvalid.js:2:40 lint/a11y/noPositiveTabindex FIXABLE ━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

1 1 │ React.createElement("div", { tabIndex: '1' })
2 │ - React.createElement("div",·{·tabIndex:·1·})
Expand All @@ -79,7 +78,7 @@ reactCreateElementInvalid.js:3:40 lint/a11y/noPositiveTabindex FIXABLE ━━

i Use only 0 and -1 as tabIndex values. Avoid using tabIndex values greater than 0 and CSS properties that can change the order of focusable HTML elements.

i Unsafe fix: Replace the tableIndex prop value with 0.
i Unsafe fix: Replace the tabIndex prop value with 0.

1 1 │ React.createElement("div", { tabIndex: '1' })
2 2 │ React.createElement("div", { tabIndex: 1 })
Expand Down