fix(parser): accept scroll-state(...) in @container not queries by ruidosujeira · Pull Request #8855 · biomejs/biome

ruidosujeira · 2026-01-24T14:51:07Z

Summary

Fixes container query parsing to accept not combined with function-style queries like scroll-state(...), matching browser behavior and avoiding parser errors in @container conditions.

Fixes #8840.

Test Plan

always cargo test -p biome_css_parser --test spec_tests at_rule_container

Docs

No docs changes (parser/grammar update only).

changeset-bot · 2026-01-24T14:51:12Z

🦋 Changeset detected

Latest commit: ead8c38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-24T14:54:41Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds support for general-enclosed values inside container-query parentheses by extending the grammar union AnyCssContainerQueryInParens with an AnyCssValue alternative. The parser now recognises function-form queries (identifier followed by '(') and includes new predicates and handlers to parse scroll-state(...) via parse_any_value. The CSS formatter receives a new match arm to format AnyCssValue. Three parser tests covering not/grouping with scroll-state(...) were added and a changeset records the fix for the related issue.

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarises the main change: accepting scroll-state(...) in `@container` not queries, which directly matches the changeset's parser fixes.
Description check	✅ Passed	The description is well-related to the changeset, explaining the parser fix for container queries with negation and scroll-state functions, referencing issue `#8840`.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#8840` by enabling the parser to accept 'not scroll-state(...)' and similar negated function-style queries in `@container` conditions, with added test coverage for the three reported forms.
Out of Scope Changes check	✅ Passed	All changes are tightly scoped to the container query parsing issue: grammar updates, parser logic, formatter support, and test cases—no unrelated modifications detected.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2026-01-24T15:05:09Z

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 127 skipped benchmarks¹

_{Comparing ruidosujeira:fix/8840-container-not-scroll-state (ead8c38) with main (086a0c5)}

127 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico

It seems the changes aren't correct because we're now parsing incorrect syntax as correct

ematipico · 2026-01-24T16:06:47Z

...ts/css_test_suite/error/at_rule/at_rule_container/at_rule_container_and_query_error.css.snap

  > 22 │ @container (width > 300px) and and (height > 200px) {
-       │                                ^^^
+       │                                            ^^^^^^^
    23 │ }
    24 │ 

  i Expected one of:

-  - ( <container-query> )
-  - ( <size-feature> )
-  - style( <style-query> )
+  - identifier
+  - string
+  - number
+  - dimension
+  - ratio
+  - custom property
+  - function


This seems to be a regression. We're now parsing a double and and

ematipico · 2026-01-24T16:08:33Z

...sts/css_test_suite/error/at_rule/at_rule_container/at_rule_container_or_query_error.css.snap

+              2: CSS_BOGUS@566..580
+                0: CSS_BOGUS@566..580
+                  0: CSS_BOGUS@566..580
+                    0: CSS_BOGUS@566..580


We went from 2 bogus nodes to 4 bogus nodes. It seems we worsened the already brittle recovering

ruidosujeira · 2026-02-13T17:25:47Z

Restricted container-query function parsing to scroll-state(...) only and removed the generic parse_any_value fallback.
This restores proper diagnostics for invalid chains like and and / or or and improves recovery.

All at_rule_container tests are passing.

.changeset/loose-eyes-roll.md

ematipico · 2026-02-18T09:01:13Z

.changeset/loose-eyes-roll.md

+"@biomejs/biome": patch
+---
+
+Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses  `not + scroll-state` inside `@container` queries.


Suggested change

Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses `not + scroll-state` inside `@container` queries.

Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses `not + scroll-state` inside `@container` queries.

ematipico · 2026-02-18T09:30:06Z

@ruidosujeira can you please fix the conflict?

ruidosujeira · 2026-02-18T17:52:14Z

@ematipico I managed to resolve the conflicts.

.changeset/loose-eyes-roll.md

github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels Jan 24, 2026

ruidosujeira changed the title ~~fix/ Parser error when combining not and scroll-state in @container query~~ fix(parser): accept scroll-state(...) in @container not queries Jan 24, 2026

ematipico requested changes Jan 24, 2026

View reviewed changes

ematipico reviewed Feb 18, 2026

View reviewed changes

.changeset/loose-eyes-roll.md Outdated Show resolved Hide resolved

ematipico approved these changes Feb 18, 2026

View reviewed changes

ruidosujeira and others added 4 commits February 18, 2026 14:38

fix Parser error when combining not and scroll-state in @container query

8c73545

[autofix.ci] apply automated fixes

eb3265e

add changeset

d5622b1

fix(parser): restrict container function queries to scroll-state

e66c941

ruidosujeira force-pushed the fix/8840-container-not-scroll-state branch from 4bc93a8 to e66c941 Compare February 18, 2026 17:39

ematipico reviewed Feb 18, 2026

View reviewed changes

.changeset/loose-eyes-roll.md Outdated Show resolved Hide resolved

Apply suggestion from @ematipico

ead8c38

ematipico merged commit 6918c9e into biomejs:main Feb 18, 2026
17 checks passed

github-actions bot mentioned this pull request Feb 18, 2026

ci: release #9116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(parser): accept scroll-state(...) in @container not queries#8855

fix(parser): accept scroll-state(...) in @container not queries#8855
ematipico merged 5 commits intobiomejs:mainfrom
ruidosujeira:fix/8840-container-not-scroll-state

ruidosujeira commented Jan 24, 2026

Uh oh!

changeset-bot bot commented Jan 24, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 24, 2026 •

edited

Loading

Reviews paused

Uh oh!

codspeed-hq bot commented Jan 24, 2026 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

ematipico Jan 24, 2026

Uh oh!

ematipico Jan 24, 2026

Uh oh!

ruidosujeira commented Feb 13, 2026

Uh oh!

Uh oh!

ematipico Feb 18, 2026

Uh oh!

ematipico commented Feb 18, 2026

Uh oh!

ruidosujeira commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses `not + scroll-state` inside `@container` queries.
	Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses `not + scroll-state` inside `@container` queries.

Uh oh!

Conversation

ruidosujeira commented Jan 24, 2026

Uh oh!

changeset-bot bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Suggested reviewers

Uh oh!

codspeed-hq bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

ematipico Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

ematipico Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

ruidosujeira commented Feb 13, 2026

Uh oh!

Uh oh!

ematipico Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

ematipico commented Feb 18, 2026

Uh oh!

ruidosujeira commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jan 24, 2026 •

edited

Loading

coderabbitai bot commented Jan 24, 2026 •

edited

Loading

codspeed-hq bot commented Jan 24, 2026 •

edited

Loading