Skip to content

fix(parser): accept scroll-state(...) in @container not queries #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 5 commits into from
Feb 18, 2026
Merged

fix(parser): accept scroll-state(...) in @container not queries #8855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c73545
fix Parser error when combining not and scroll-state in @container query
ruidosujeira Jan 24, 2026
eb3265e
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 24, 2026
d5622b1
add changeset
ruidosujeira Jan 24, 2026
e66c941
fix(parser): restrict container function queries to scroll-state
ruidosujeira Feb 13, 2026
ead8c38
Apply suggestion from @ematipico
ematipico Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loose-eyes-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed [#8840](https://github.com/biomejs/biome/issues/8840). Now the Biome CSS parser correctly parses `not + scroll-state` inside `@container` queries.
1 change: 1 addition & 0 deletions crates/biome_css_formatter/src/css/any/container_query_in_parens.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ impl FormatRule<AnyCssContainerQueryInParens> for FormatAnyCssContainerQueryInPa
type Context = CssFormatContext;
fn fmt(&self, node: &AnyCssContainerQueryInParens, f: &mut CssFormatter) -> FormatResult<()> {
match node {
AnyCssContainerQueryInParens::AnyCssValue(node) => node.format().fmt(f),
AnyCssContainerQueryInParens::CssContainerQueryInParens(node) => node.format().fmt(f),
AnyCssContainerQueryInParens::CssContainerSizeFeatureInParens(node) => {
node.format().fmt(f)
Expand Down
26 changes: 24 additions & 2 deletions crates/biome_css_parser/src/syntax/at_rule/container/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ use crate::syntax::at_rule::error::{
use crate::syntax::at_rule::feature::{expected_any_query_feature, parse_any_query_feature};
use crate::syntax::block::parse_conditional_block;
use crate::syntax::parse_error::expected_non_css_wide_keyword_identifier;
use crate::syntax::{is_at_declaration, parse_custom_identifier, parse_declaration};
use crate::syntax::value::function::is_nth_at_function;
use crate::syntax::{
is_at_declaration, parse_any_value, parse_custom_identifier, parse_declaration,
};
use biome_css_syntax::CssSyntaxKind::*;
use biome_css_syntax::{CssSyntaxKind, T};
use biome_parser::parse_recovery::ParseRecovery;
Expand Down Expand Up @@ -199,6 +202,20 @@ fn is_at_container_not_query(p: &mut CssParser) -> bool {
p.at(T![not])
}

#[inline]
fn is_at_container_scroll_state_query(p: &mut CssParser) -> bool {
is_nth_at_function(p, 0) && p.cur_text().eq_ignore_ascii_case("scroll-state")
}

#[inline]
fn parse_container_scroll_state_query(p: &mut CssParser) -> ParsedSyntax {
if !is_at_container_scroll_state_query(p) {
return Absent;
}

parse_any_value(p)
}

/// Parses a negated container query using the `not(...)` syntax.
///
/// # Example
Expand Down Expand Up @@ -233,14 +250,19 @@ pub(crate) fn parse_any_container_query_in_parens(p: &mut CssParser) -> ParsedSy
parse_container_query_in_parens(p)
} else if is_at_container_size_feature_in_parens(p) {
parse_container_size_feature_in_parens(p)
} else if is_at_container_scroll_state_query(p) {
parse_container_scroll_state_query(p)
} else {
Absent
}
}

#[inline]
fn is_at_container_query_in_parens(p: &mut CssParser) -> bool {
p.at(T!['(']) && (p.nth_at(1, T![not]) || p.nth_at(1, T!['(']))
p.at(T!['('])
&& (p.nth_at(1, T![not])
|| p.nth_at(1, T!['('])
|| (p.nth_at(1, T![ident]) && p.nth_at(2, T!['('])))
}

/// Parses a parenthesized container query.
Expand Down
1 change: 1 addition & 0 deletions ...css_test_suite/error/at_rule/at_rule_container/at_rule_container_and_query_error.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
source: crates/biome_css_parser/tests/spec_test.rs
assertion_line: 179
expression: snapshot
---

Expand Down
1 change: 1 addition & 0 deletions .../css_test_suite/error/at_rule/at_rule_container/at_rule_container_or_query_error.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
source: crates/biome_css_parser/tests/spec_test.rs
assertion_line: 179
expression: snapshot
---

Expand Down
6 changes: 6 additions & 0 deletions crates/biome_css_parser/tests/css_test_suite/ok/at_rule/at_rule_container.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,9 @@
@container name not style(color: red) {}

@container style (--responsive: true) { }

@container not scroll-state(stuck) { }

@container not (scroll-state(stuck)) { }

@container (not scroll-state(stuck)) { }
198 changes: 194 additions & 4 deletions crates/biome_css_parser/tests/css_test_suite/ok/at_rule/at_rule_container.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ expression: snapshot

@container style (--responsive: true) { }

@container not scroll-state(stuck) { }

@container not (scroll-state(stuck)) { }

@container (not scroll-state(stuck)) { }

```


Expand Down Expand Up @@ -766,17 +772,128 @@ CssRoot {
},
},
},
CssAtRule {
at_token: AT@891..894 "@" [Newline("\n"), Newline("\n")] [],
rule: CssContainerAtRule {
declarator: CssContainerAtRuleDeclarator {
container_token: CONTAINER_KW@894..904 "container" [] [Whitespace(" ")],
name: CssCustomIdentifier {
value_token: IDENT@904..908 "not" [] [Whitespace(" ")],
},
query: CssFunction {
name: CssIdentifier {
value_token: IDENT@908..920 "scroll-state" [] [],
},
l_paren_token: L_PAREN@920..921 "(" [] [],
items: CssParameterList [
CssParameter {
any_css_expression: CssListOfComponentValuesExpression {
css_component_value_list: CssComponentValueList [
CssIdentifier {
value_token: IDENT@921..926 "stuck" [] [],
},
],
},
},
],
r_paren_token: R_PAREN@926..928 ")" [] [Whitespace(" ")],
},
},
block: CssRuleBlock {
l_curly_token: L_CURLY@928..931 "{" [] [Whitespace(" ")],
rules: CssRuleList [],
r_curly_token: R_CURLY@931..932 "}" [] [],
},
},
},
CssAtRule {
at_token: AT@932..935 "@" [Newline("\n"), Newline("\n")] [],
rule: CssContainerAtRule {
declarator: CssContainerAtRuleDeclarator {
container_token: CONTAINER_KW@935..945 "container" [] [Whitespace(" ")],
name: CssCustomIdentifier {
value_token: IDENT@945..949 "not" [] [Whitespace(" ")],
},
query: CssContainerQueryInParens {
l_paren_token: L_PAREN@949..950 "(" [] [],
query: CssFunction {
name: CssIdentifier {
value_token: IDENT@950..962 "scroll-state" [] [],
},
l_paren_token: L_PAREN@962..963 "(" [] [],
items: CssParameterList [
CssParameter {
any_css_expression: CssListOfComponentValuesExpression {
css_component_value_list: CssComponentValueList [
CssIdentifier {
value_token: IDENT@963..968 "stuck" [] [],
},
],
},
},
],
r_paren_token: R_PAREN@968..969 ")" [] [],
},
r_paren_token: R_PAREN@969..971 ")" [] [Whitespace(" ")],
},
},
block: CssRuleBlock {
l_curly_token: L_CURLY@971..974 "{" [] [Whitespace(" ")],
rules: CssRuleList [],
r_curly_token: R_CURLY@974..975 "}" [] [],
},
},
},
CssAtRule {
at_token: AT@975..978 "@" [Newline("\n"), Newline("\n")] [],
rule: CssContainerAtRule {
declarator: CssContainerAtRuleDeclarator {
container_token: CONTAINER_KW@978..988 "container" [] [Whitespace(" ")],
name: missing (optional),
query: CssContainerQueryInParens {
l_paren_token: L_PAREN@988..989 "(" [] [],
query: CssContainerNotQuery {
not_token: NOT_KW@989..993 "not" [] [Whitespace(" ")],
query: CssFunction {
name: CssIdentifier {
value_token: IDENT@993..1005 "scroll-state" [] [],
},
l_paren_token: L_PAREN@1005..1006 "(" [] [],
items: CssParameterList [
CssParameter {
any_css_expression: CssListOfComponentValuesExpression {
css_component_value_list: CssComponentValueList [
CssIdentifier {
value_token: IDENT@1006..1011 "stuck" [] [],
},
],
},
},
],
r_paren_token: R_PAREN@1011..1012 ")" [] [],
},
},
r_paren_token: R_PAREN@1012..1014 ")" [] [Whitespace(" ")],
},
},
block: CssRuleBlock {
l_curly_token: L_CURLY@1014..1017 "{" [] [Whitespace(" ")],
rules: CssRuleList [],
r_curly_token: R_CURLY@1017..1018 "}" [] [],
},
},
},
],
eof_token: EOF@891..892 "" [Newline("\n")] [],
eof_token: EOF@1018..1019 "" [Newline("\n")] [],
}
```

## CST

```
0: CSS_ROOT@0..892
0: CSS_ROOT@0..1019
0: (empty)
1: CSS_ROOT_ITEM_LIST@0..891
1: CSS_ROOT_ITEM_LIST@0..1018
0: CSS_AT_RULE@0..41
0: AT@0..1 "@" [] []
1: CSS_CONTAINER_AT_RULE@1..41
Expand Down Expand Up @@ -1270,6 +1387,79 @@ CssRoot {
0: L_CURLY@887..890 "{" [] [Whitespace(" ")]
1: CSS_RULE_LIST@890..890
2: R_CURLY@890..891 "}" [] []
2: EOF@891..892 "" [Newline("\n")] []
20: CSS_AT_RULE@891..932
0: AT@891..894 "@" [Newline("\n"), Newline("\n")] []
1: CSS_CONTAINER_AT_RULE@894..932
0: CSS_CONTAINER_AT_RULE_DECLARATOR@894..928
0: CONTAINER_KW@894..904 "container" [] [Whitespace(" ")]
1: CSS_CUSTOM_IDENTIFIER@904..908
0: IDENT@904..908 "not" [] [Whitespace(" ")]
2: CSS_FUNCTION@908..928
0: CSS_IDENTIFIER@908..920
0: IDENT@908..920 "scroll-state" [] []
1: L_PAREN@920..921 "(" [] []
2: CSS_PARAMETER_LIST@921..926
0: CSS_PARAMETER@921..926
0: CSS_LIST_OF_COMPONENT_VALUES_EXPRESSION@921..926
0: CSS_COMPONENT_VALUE_LIST@921..926
0: CSS_IDENTIFIER@921..926
0: IDENT@921..926 "stuck" [] []
3: R_PAREN@926..928 ")" [] [Whitespace(" ")]
1: CSS_RULE_BLOCK@928..932
0: L_CURLY@928..931 "{" [] [Whitespace(" ")]
1: CSS_RULE_LIST@931..931
2: R_CURLY@931..932 "}" [] []
21: CSS_AT_RULE@932..975
0: AT@932..935 "@" [Newline("\n"), Newline("\n")] []
1: CSS_CONTAINER_AT_RULE@935..975
0: CSS_CONTAINER_AT_RULE_DECLARATOR@935..971
0: CONTAINER_KW@935..945 "container" [] [Whitespace(" ")]
1: CSS_CUSTOM_IDENTIFIER@945..949
0: IDENT@945..949 "not" [] [Whitespace(" ")]
2: CSS_CONTAINER_QUERY_IN_PARENS@949..971
0: L_PAREN@949..950 "(" [] []
1: CSS_FUNCTION@950..969
0: CSS_IDENTIFIER@950..962
0: IDENT@950..962 "scroll-state" [] []
1: L_PAREN@962..963 "(" [] []
2: CSS_PARAMETER_LIST@963..968
0: CSS_PARAMETER@963..968
0: CSS_LIST_OF_COMPONENT_VALUES_EXPRESSION@963..968
0: CSS_COMPONENT_VALUE_LIST@963..968
0: CSS_IDENTIFIER@963..968
0: IDENT@963..968 "stuck" [] []
3: R_PAREN@968..969 ")" [] []
2: R_PAREN@969..971 ")" [] [Whitespace(" ")]
1: CSS_RULE_BLOCK@971..975
0: L_CURLY@971..974 "{" [] [Whitespace(" ")]
1: CSS_RULE_LIST@974..974
2: R_CURLY@974..975 "}" [] []
22: CSS_AT_RULE@975..1018
0: AT@975..978 "@" [Newline("\n"), Newline("\n")] []
1: CSS_CONTAINER_AT_RULE@978..1018
0: CSS_CONTAINER_AT_RULE_DECLARATOR@978..1014
0: CONTAINER_KW@978..988 "container" [] [Whitespace(" ")]
1: (empty)
2: CSS_CONTAINER_QUERY_IN_PARENS@988..1014
0: L_PAREN@988..989 "(" [] []
1: CSS_CONTAINER_NOT_QUERY@989..1012
0: NOT_KW@989..993 "not" [] [Whitespace(" ")]
1: CSS_FUNCTION@993..1012
0: CSS_IDENTIFIER@993..1005
0: IDENT@993..1005 "scroll-state" [] []
1: L_PAREN@1005..1006 "(" [] []
2: CSS_PARAMETER_LIST@1006..1011
0: CSS_PARAMETER@1006..1011
0: CSS_LIST_OF_COMPONENT_VALUES_EXPRESSION@1006..1011
0: CSS_COMPONENT_VALUE_LIST@1006..1011
0: CSS_IDENTIFIER@1006..1011
0: IDENT@1006..1011 "stuck" [] []
3: R_PAREN@1011..1012 ")" [] []
2: R_PAREN@1012..1014 ")" [] [Whitespace(" ")]
1: CSS_RULE_BLOCK@1014..1018
0: L_CURLY@1014..1017 "{" [] [Whitespace(" ")]
1: CSS_RULE_LIST@1017..1017
2: R_CURLY@1017..1018 "}" [] []
2: EOF@1018..1019 "" [Newline("\n")] []

```
Loading
Loading