fix(cli): improve RuleName ordering and update summary snapshots close #8730#8771
fix(cli): improve RuleName ordering and update summary snapshots close #8730#8771dyc3 merged 3 commits intobiomejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 4087795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe change tightens ordering for Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ematipico
left a comment
There was a problem hiding this comment.
Please add a changeset as per the contribution guide. And fix the PR title
close #8730
The original implementation only compared lengths; RuleNames of the same length were considered to be the same key.
Summary
Updated the Ord implementation for RuleName to use tuple comparison for length and name, ensuring stable ordering. Adjusted test snapshots to reflect the new rule ordering and diagnostic counts in summary reports.
Test Plan
Docs