Skip to content

ci: make it so windows devs don't get lints that don't show up on linux/macos#7003

Merged
dyc3 merged 2 commits intomainfrom
ci-lint
Jul 28, 2025
Merged

ci: make it so windows devs don't get lints that don't show up on linux/macos#7003
dyc3 merged 2 commits intomainfrom
ci-lint

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Jul 25, 2025

Summary

This makes it so that all our code also gets linted on a windows machine in CI.

The reason for this is that it seems --all-targets does not make cargo clippy evaluate lints from the context of all platforms. This means that if a lint appears on windows from conditional os-specific code, then that lint won't appear when running clippy on linux, for example.

#6923 (comment)

We also weren't linting with --all-features, so I added that too.

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025

⚠️ No Changeset found

Latest commit: 192757e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jul 25, 2025
@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50627 50627 0
Passed 49357 49357 0
Failed 1270 1270 0
Panics 0 0 0
Coverage 97.49% 97.49% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6706 6706 0
Passed 2245 2245 0
Failed 4461 4461 0
Panics 0 0 0
Coverage 33.48% 33.48% 0.00%

ts/babel

Test result main count This PR count Difference
Total 822 822 0
Passed 731 731 0
Failed 91 91 0
Panics 0 0 0
Coverage 88.93% 88.93% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18785 18785 0
Passed 14413 14413 0
Failed 4372 4372 0
Panics 0 0 0
Coverage 76.73% 76.73% 0.00%

@dyc3 dyc3 marked this pull request as ready for review July 28, 2025 15:25
@dyc3
Copy link
Contributor Author

dyc3 commented Jul 28, 2025

Since the CI failure looks unrelated to this PR, I'm gonna go ahead and merge it (after a rebase)

@dyc3 dyc3 merged commit e5745c3 into main Jul 28, 2025
12 checks passed
@dyc3 dyc3 deleted the ci-lint branch July 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Tooling Area: internal tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants