feat(qwik): add domain setup and enable some pre-existing rules by ptkagori · Pull Request #6923 · biomejs/biome

ptkagori · 2025-07-17T20:24:36Z

Summary

This PR adds Qwik domain support to Biome, allowing Qwik developers to use Biome for linting and formatting.
It introduces the Qwik domain infrastructure and enables two rules for Qwik projects:

Test Plan

All tests pass, including those for Qwik rules.
Verified that Qwik projects receive diagnostics for these rules.

Docs

Rule and domain documentation is included in code comments and examples.
Added: add Qwik domain documentation website#2727 to sync addition of Qwik domain with website

changeset-bot · 2025-07-17T20:24:40Z

🦋 Changeset detected

Latest commit: 5306ecb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2025-07-17T20:49:53Z

CodSpeed Performance Report

Merging #6923 will not alter performance

_{Comparing ptkagori:feat/qwik-update-rules (5306ecb) with next (b510e6f)}

Summary

✅ 115 untouched benchmarks

ematipico · 2025-07-17T22:05:43Z

@ptkagori, as said in the other PR and highlighted in her https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#creating-pull-requests, this PR must be merged into the next branch. I tried to change the base, but it seems that something didn't work. Can you make sure that this PR is directed to next?

.changeset/ripe-eyes-fix.md

dyc3 · 2025-07-24T17:24:01Z

crates/biome_cli/src/service/windows.rs

The changes to this file looks unrelated.

@dyc3 , added those changes in abid to resolve the CI check failures below. while I now run the failing commands locally without issues, I still see the CI failures. Any insights on this?

There's a bunch of removed imports in crates/biome_service/src/workspace/scanner.tests.rs

dyc3 · 2025-07-24T23:35:29Z

crates/biome_service/src/workspace/scanner.tests.rs

-use std::sync::Arc;
-
-use biome_fs::{BiomePath, TemporaryFs};
-use crossbeam::channel::bounded;
-use tokio::sync::watch;
-
-use crate::{
-    Workspace, WorkspaceServer,
-    workspace::{OpenProjectParams, ScanKind, ScanProjectFolderParams, ServiceDataNotification},
-};
-


These should not be removed. Would you happen to be doing development on a windows machine?

yes I am doing on windows
jfyi, I'm running each of the failing CI commands e.g for formatting and linting to recreate the failure in local then fixing with only the minimal changes highlighted. That's how we have additional changes

Right, I see what's happening. Because the code in this file targets macos and linux, the linter would mark these as unused, and you fixed the lint to make it happy. That indicates a problem with CI, but it doesn't necessarily block this PR.

You'll need to revert the changes to these files.

sure, sounds good!

.changeset/ripe-eyes-fix.md

…biome into feat/qwik-update-rules

dyc3 · 2025-07-25T21:55:02Z

crates/biome_module_graph/tests/snapshots/test_resolve_type_of_property_with_getter.snap

This file needs to be reverted.

ematipico · 2025-07-25T22:55:11Z

@ptkagori do you need some help with the PR?

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com> Co-authored-by: dyc3 <1808807+dyc3@users.noreply.github.com>

github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jul 17, 2025

github-actions bot removed A-Project Area: project A-Formatter Area: formatter labels Jul 17, 2025

ematipico changed the base branch from main to next July 17, 2025 22:03

ematipico changed the base branch from next to main July 17, 2025 22:04

ptkagori force-pushed the feat/qwik-update-rules branch from 896fdc2 to fbed3af Compare July 18, 2025 15:02

github-actions bot added the A-Diagnostic Area: diagnostocis label Jul 18, 2025

ptkagori force-pushed the feat/qwik-update-rules branch from fbed3af to c4613a6 Compare July 18, 2025 15:25

github-actions bot removed the A-Diagnostic Area: diagnostocis label Jul 18, 2025

ptkagori changed the base branch from main to next July 18, 2025 15:32

ptkagori force-pushed the feat/qwik-update-rules branch from c4613a6 to f519a1d Compare July 18, 2025 15:34

ptkagori changed the title ~~Feat/qwik update rules~~ Add Qwik Domain and enabled pre-existing rules Jul 18, 2025

ptkagori mentioned this pull request Jul 18, 2025

feat(qwik): add few new lint rules #6887

Merged

ptkagori changed the title ~~Add Qwik Domain and enabled pre-existing rules~~ feat: Add Qwik Domain and enabled pre-existing rules Jul 18, 2025

ptkagori changed the title ~~feat: Add Qwik Domain and enabled pre-existing rules~~ feat(qwik): add domain setup and enable some pre-existing rules Jul 18, 2025

ematipico approved these changes Jul 18, 2025

View reviewed changes

.changeset/ripe-eyes-fix.md Outdated Show resolved Hide resolved

github-actions bot added A-Core Area: core A-Project Area: project A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JSON Language: JSON and super languages labels Jul 21, 2025

ematipico added this to the Biome v2.2 milestone Jul 22, 2025

dyc3 reviewed Jul 24, 2025

View reviewed changes

dyc3 mentioned this pull request Jul 25, 2025

ci: make it so windows devs don't get lints that don't show up on linux/macos #7003

Merged

ptkagori force-pushed the feat/qwik-update-rules branch from 41528ae to 38b2691 Compare July 25, 2025 16:22

github-actions bot removed A-Project Area: project A-Resolver Area: resolver labels Jul 25, 2025

ematipico reviewed Jul 25, 2025

View reviewed changes

.changeset/ripe-eyes-fix.md Outdated Show resolved Hide resolved

ematipico and others added 3 commits July 25, 2025 17:23

Update .changeset/ripe-eyes-fix.md

ec288ed

chore: resolve failing PR CI failure (test)

c189ec4

Merge branch 'feat/qwik-update-rules' of https://github.com/ptkagori/…

2577507

…biome into feat/qwik-update-rules

github-actions bot added the A-Project Area: project label Jul 25, 2025

dyc3 reviewed Jul 25, 2025

View reviewed changes

crates/biome_module_graph/tests/snapshots/test_resolve_type_of_property_with_getter.snap

Copy link

Contributor

dyc3 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be reverted.

chore: fixed failing CI tests

a4f0949

ematipico added 2 commits July 26, 2025 18:02

fix tests

c2cf5c4

Merge remote-tracking branch 'origin/next' into feat/qwik-update-rules

5306ecb

ematipico merged commit 0589f08 into biomejs:next Jul 28, 2025
27 of 28 checks passed

github-actions bot mentioned this pull request Aug 13, 2025

ci: release #7157

Merged

Uh oh!

Conversation

ptkagori commented Jul 17, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6923 will not alter performance

Summary

Uh oh!

ematipico commented Jul 17, 2025

Uh oh!

Uh oh!

dyc3 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

ptkagori Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dyc3 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

dyc3 Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptkagori Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

dyc3 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ptkagori Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dyc3 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ematipico commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jul 17, 2025 •

edited

Loading

codspeed-hq bot commented Jul 17, 2025 •

edited

Loading

ptkagori Jul 24, 2025 •

edited

Loading

dyc3 Jul 24, 2025 •

edited

Loading