Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix hook linting message grammar #580

Merged
merged 2 commits into from
Oct 23, 2023
Merged

chore: fix hook linting message grammar #580

merged 2 commits into from
Oct 23, 2023

Conversation

crutchcorn
Copy link
Contributor

Summary

I noticed while working on a project that there was a slight grammar error in one of the newer rules. This PR fixes that and closes #579

Test Plan

Run linter over the following code, see new message:

import {useEffect} from "react";

const Comp = () => {
    const test = 0;

    useEffect(() => {console.log(test)}, []);

    return null;
}

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Oct 22, 2023
@nissy-dev
Copy link
Contributor

Thank you for contributions!
Could you run the just ready command and commit the unstaged files?

@crutchcorn
Copy link
Contributor Author

@nissy-dev I ran the command, and it seems to've formatted one of my files, but I also ran into the following:

image

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crutchcorn !

@ematipico ematipico merged commit 6f72cf5 into biomejs:main Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Incorrect Grammar in React Hooks Rule
3 participants