Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Incorrect Grammar in React Hooks Rule #579

Closed
1 task done
crutchcorn opened this issue Oct 22, 2023 · 0 comments · Fixed by #580
Closed
1 task done

🐛 Incorrect Grammar in React Hooks Rule #579

crutchcorn opened this issue Oct 22, 2023 · 0 comments · Fixed by #580

Comments

@crutchcorn
Copy link
Contributor

crutchcorn commented Oct 22, 2023

Environment information

↳  pnpm biome rage
CLI:
  Version:                      1.3.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v18.16.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.9.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

Within the useExhaustiveDependencies rule, I noticed that the grammar is off on this rule warning:

This hook do not specify all of its dependencies.

Expected result

I believe the error should be:

This hook does not specify all of its dependencies.

Instead.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant