Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix hook linting message grammar #580

Merged
merged 2 commits into from
Oct 23, 2023
Merged

chore: fix hook linting message grammar #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e399c
chore: fix hook linting message grammar
crutchcorn Oct 22, 2023
2bbe3d7
chore: run ready command
crutchcorn Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/biome_js_analyze/src/semantic_analyzers/correctness/use_exhaustive_dependencies.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ impl Rule for UseExhaustiveDependencies {
rule_category!(),
use_effect_range,
markup! {
"This hook do not specify all of its dependencies."
"This hook does not specify all of its dependencies."
},
);

Expand Down
2 changes: 1 addition & 1 deletion ...yze/tests/specs/correctness/useExhaustiveDependencies/checkHooksImportedFromReact.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function MyComponent2() {
```
checkHooksImportedFromReact.js:3:9 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
1 │ function MyComponent1() {
2 │ let a = 1;
Expand Down
4 changes: 2 additions & 2 deletions crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/customHook.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function MyComponent() {
```
customHook.js:5:5 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
3 │ function MyComponent() {
4 │ let a = 1;
Expand All @@ -46,7 +46,7 @@ customHook.js:5:5 lint/correctness/useExhaustiveDependencies ━━━━━━
```
customHook.js:8:5 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
6 │ console.log(a);
7 │ });
Expand Down
2 changes: 1 addition & 1 deletion ...nalyze/tests/specs/correctness/useExhaustiveDependencies/extraDependenciesInvalid.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ extraDependenciesInvalid.js:28:3 lint/correctness/useExhaustiveDependencies ━
```
extraDependenciesInvalid.js:28:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
26 │ function MyComponent1() {
27 │ let someObj = getObj();
Expand Down
48 changes: 24 additions & 24 deletions ...lyze/tests/specs/correctness/useExhaustiveDependencies/missingDependenciesInvalid.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ function MyComponent13() {
```
missingDependenciesInvalid.js:7:5 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
5 │ let a = 1;
6 │ const b = a + 1;
Expand All @@ -160,7 +160,7 @@ missingDependenciesInvalid.js:7:5 lint/correctness/useExhaustiveDependencies ━
```
missingDependenciesInvalid.js:7:5 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
5 │ let a = 1;
6 │ const b = a + 1;
Expand All @@ -184,7 +184,7 @@ missingDependenciesInvalid.js:7:5 lint/correctness/useExhaustiveDependencies ━
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -208,7 +208,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -232,7 +232,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -256,7 +256,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -280,7 +280,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -304,7 +304,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
19 │ const deferredValue = useDeferredValue(value);
20 │ const [isPending, startTransition] = useTransition();
Expand All @@ -327,7 +327,7 @@ missingDependenciesInvalid.js:21:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:41:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
39 │ function MyComponent3() {
40 │ let a = 1;
Expand All @@ -351,7 +351,7 @@ missingDependenciesInvalid.js:41:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:42:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
40 │ let a = 1;
41 │ useEffect(() => console.log(a));
Expand All @@ -375,7 +375,7 @@ missingDependenciesInvalid.js:42:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:43:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
41 │ useEffect(() => console.log(a));
42 │ useCallback(() => console.log(a));
Expand All @@ -399,7 +399,7 @@ missingDependenciesInvalid.js:43:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:44:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
42 │ useCallback(() => console.log(a));
43 │ useMemo(() => console.log(a));
Expand All @@ -423,7 +423,7 @@ missingDependenciesInvalid.js:44:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:45:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
43 │ useMemo(() => console.log(a));
44 │ useImperativeHandle(ref, () => console.log(a));
Expand All @@ -447,7 +447,7 @@ missingDependenciesInvalid.js:45:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:46:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
44 │ useImperativeHandle(ref, () => console.log(a));
45 │ useLayoutEffect(() => console.log(a));
Expand All @@ -471,7 +471,7 @@ missingDependenciesInvalid.js:46:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:53:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
51 │ function MyComponent4() {
52 │ let a = 1;
Expand All @@ -495,7 +495,7 @@ missingDependenciesInvalid.js:53:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:62:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
60 │ function MyComponent5() {
61 │ let a = 1;
Expand Down Expand Up @@ -528,7 +528,7 @@ missingDependenciesInvalid.js:62:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:72:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
70 │ function MyComponent6() {
71 │ let someObj = getObj();
Expand All @@ -552,7 +552,7 @@ missingDependenciesInvalid.js:72:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:78:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
77 │ const MyComponent7 = React.memo(function ({ a }) {
> 78 │ useEffect(() => {
Expand All @@ -575,7 +575,7 @@ missingDependenciesInvalid.js:78:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:84:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
83 │ const MyComponent8 = React.memo(({ a }) => {
> 84 │ useEffect(() => {
Expand All @@ -598,7 +598,7 @@ missingDependenciesInvalid.js:84:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:92:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
90 │ export function MyComponent9() {
91 │ let a = 1;
Expand All @@ -622,7 +622,7 @@ missingDependenciesInvalid.js:92:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:99:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
97 │ export default function MyComponent10() {
98 │ let a = 1;
Expand All @@ -646,7 +646,7 @@ missingDependenciesInvalid.js:99:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:107:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
105 │ function MyComponent11() {
106 │ let a = 1;
Expand All @@ -670,7 +670,7 @@ missingDependenciesInvalid.js:107:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:114:3 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
112 │ function MyComponent12() {
113 │ let a = 1;
Expand All @@ -694,7 +694,7 @@ missingDependenciesInvalid.js:114:3 lint/correctness/useExhaustiveDependencies
```
missingDependenciesInvalid.js:122:9 lint/correctness/useExhaustiveDependencies ━━━━━━━━━━━━━━━━━━━━━
! This hook do not specify all of its dependencies.
! This hook does not specify all of its dependencies.
120 │ function MyComponent13() {
121 │ let a = 1;
Expand Down
4 changes: 2 additions & 2 deletions website/src/content/docs/linter/rules/use-exhaustive-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function component() {

<pre class="language-text"><code class="language-text">correctness/useExhaustiveDependencies.js:5:5 <a href="https://biomejs.dev/linter/rules/use-exhaustive-dependencies">lint/correctness/useExhaustiveDependencies</a> ━━━━━━━━━━━━

<strong><span style="color: Tomato;"> </span></strong><strong><span style="color: Tomato;">✖</span></strong> <span style="color: Tomato;">This hook do not specify all of its dependencies.</span>
<strong><span style="color: Tomato;"> </span></strong><strong><span style="color: Tomato;">✖</span></strong> <span style="color: Tomato;">This hook does not specify all of its dependencies.</span>

<strong>3 │ </strong>function component() {
<strong>4 │ </strong> let a = 1;
Expand Down Expand Up @@ -151,7 +151,7 @@ function component() {

<pre class="language-text"><code class="language-text">correctness/useExhaustiveDependencies.js:6:5 <a href="https://biomejs.dev/linter/rules/use-exhaustive-dependencies">lint/correctness/useExhaustiveDependencies</a> ━━━━━━━━━━━━

<strong><span style="color: Tomato;"> </span></strong><strong><span style="color: Tomato;">✖</span></strong> <span style="color: Tomato;">This hook do not specify all of its dependencies.</span>
<strong><span style="color: Tomato;"> </span></strong><strong><span style="color: Tomato;">✖</span></strong> <span style="color: Tomato;">This hook does not specify all of its dependencies.</span>

<strong>4 │ </strong> let a = 1;
<strong>5 │ </strong> const b = a + 1;
Expand Down