-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_css_analyze): noDuplicateSelectorsKeyframeBlock #2534
Conversation
CodSpeed Performance ReportMerging #2534 will improve performances by 17.64%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you run just gen-lint
to pass CI?
crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs
Outdated
Show resolved
Hide resolved
@keyframes foo { from {} from {}} | ||
|
||
@keyframes foo { from {} FROM {}} | ||
|
||
@keyframes foo { 0% {} 0% {}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: ty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
rule_category!(), | ||
node.range(), | ||
markup! { | ||
"Unexpected duplicate selector: "<Emphasis>{node.text()}</Emphasis> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@togami2864 can you please follow up on this rule? Let's remember that we want to follow the rule pillars: https://biomejs.dev/linter/#rule-pillars
This rule doesn't explain why two duplicated selectors are wrong.
Summary
this PR adds lint support to remove duplicate selector in keyframes block #2523
Test Plan
spec test