feat(biome_css_analyze): noDuplicateSelectorsKeyframeBlock

crates/biome_css_analyze/src/lint/nursery.rs

@@ -5,6 +5,7 @@ use biome_analyze::declare_group;
 pub mod no_color_invalid_hex;
 pub mod no_css_empty_block;
 pub mod no_duplicate_font_names;
+pub mod no_duplicate_selectors_keyframe_block;
 
 declare_group! {
     pub Nursery {
@@ -13,6 +14,7 @@ declare_group! {
             self :: no_color_invalid_hex :: NoColorInvalidHex ,
             self :: no_css_empty_block :: NoCssEmptyBlock ,
             self :: no_duplicate_font_names :: NoDuplicateFontNames ,
+            self :: no_duplicate_selectors_keyframe_block :: NoDuplicateSelectorsKeyframeBlock ,
         ]
      }
 }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs

@@ -0,0 +1,83 @@
+use std::collections::HashSet;
+
+use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic, RuleSource};
+use biome_console::markup;
+use biome_css_syntax::{AnyCssKeyframesItem, AnyCssKeyframesSelector, CssKeyframesBlock};
+use biome_rowan::AstNode;
+
+declare_rule! {
+    /// Disallow duplicate selectors within keyframe blocks.
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```css,expect_diagnostic
+    /// @keyframes foo { from {} from {} }
+    /// ```
+    ///
+    /// ```css,expect_diagnostic
+    /// @keyframes foo { from {} FROM {} }
+    /// ```
+    ///
+    /// ```css,expect_diagnostic
+    /// @keyframes foo { 0% {} 0% {} }
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```css
+    /// @keyframes foo { 0% {} 100% {} }
+    /// ```
+    ///
+    /// ```css
+    /// @keyframes foo { from {} to {} }
+    /// ```
+    ///
+    pub NoDuplicateSelectorsKeyframeBlock {
+        version: "next",
+        name: "noDuplicateSelectorsKeyframeBlock",
+        recommended: true,
+        sources:&[RuleSource::Stylelint("keyframe-block-no-duplicate-selectors")],
+    }
+}
+
+impl Rule for NoDuplicateSelectorsKeyframeBlock {
+    type Query = Ast<CssKeyframesBlock>;
+    type State = AnyCssKeyframesSelector;
+    type Signals = Option<Self::State>;
+    type Options = ();
+
+    fn run(ctx: &RuleContext<Self>) -> Option<Self::State> {
+        let node = ctx.query();
+        let mut selector_list = HashSet::new();
+        for keyframe_item in node.items() {
+            match keyframe_item {
+                AnyCssKeyframesItem::CssKeyframesItem(item) => {
+                    let keyframe_selector = item.selectors().into_iter().next()?;
+                    let keyframe_selector = keyframe_selector.ok()?;
+                    if !selector_list.insert(keyframe_selector.text().to_lowercase()) {
+                        return Some(keyframe_selector);
+                    }
+                }
+                _ => return None,
+            }
+        }
+        None
+    }
+
+    fn diagnostic(_: &RuleContext<Self>, node: &Self::State) -> Option<RuleDiagnostic> {
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                node.range(),
+                markup! {
+                    "Unexpected duplicate selector: "<Emphasis>{node.text()}</Emphasis>
+                },
+            )
+            .note(markup! {
+                    "Consider using different selector here!"
+            }),
+        )
+    }
+}

crates/biome_css_analyze/src/options.rs

@@ -8,3 +8,4 @@ pub type NoCssEmptyBlock =
     <lint::nursery::no_css_empty_block::NoCssEmptyBlock as biome_analyze::Rule>::Options;
 pub type NoDuplicateFontNames =
     <lint::nursery::no_duplicate_font_names::NoDuplicateFontNames as biome_analyze::Rule>::Options;
+pub type NoDuplicateSelectorsKeyframeBlock = < lint :: nursery :: no_duplicate_selectors_keyframe_block :: NoDuplicateSelectorsKeyframeBlock as biome_analyze :: Rule > :: Options ;

crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css

@@ -0,0 +1,5 @@
+@keyframes foo { from {} from {}}
+
+@keyframes foo { from {} FROM {}}
+
+@keyframes foo { 0% {} 0% {}}

crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css.snap

@@ -0,0 +1,60 @@
+---
+source: crates/biome_css_analyze/tests/spec_tests.rs
+expression: invalid.css
+---
+# Input
+```css
+@keyframes foo { from {} from {}}
+
+@keyframes foo { from {} FROM {}}
+
+@keyframes foo { 0% {} 0% {}}
+```
+
+# Diagnostics
+```
+invalid.css:1:26 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: from
+
+  > 1 │ @keyframes foo { from {} from {}}
+      │                          ^^^^
+    2 │ 
+    3 │ @keyframes foo { from {} FROM {}}
+
+  i Consider using different selector here!
+
+
+```
+
+```
+invalid.css:3:26 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: FROM
+
+    1 │ @keyframes foo { from {} from {}}
+    2 │ 
+  > 3 │ @keyframes foo { from {} FROM {}}
+      │                          ^^^^
+    4 │ 
+    5 │ @keyframes foo { 0% {} 0% {}}
+
+  i Consider using different selector here!
+
+
+```
+
+```
+invalid.css:5:24 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: 0%
+
+    3 │ @keyframes foo { from {} FROM {}}
+    4 │ 
+  > 5 │ @keyframes foo { 0% {} 0% {}}
+      │                        ^^
+
+  i Consider using different selector here!
+
+
+```

crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css

@@ -0,0 +1,3 @@
+@keyframes foo { from {} to {}}
+
+@keyframes foo { 0% {} 100% {}}

crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css.snap

@@ -0,0 +1,10 @@
+---
+source: crates/biome_css_analyze/tests/spec_tests.rs
+expression: valid.css
+---
+# Input
+```css
+@keyframes foo { from {} to {}}
+
+@keyframes foo { 0% {} 100% {}}
+```

crates/biome_diagnostics_categories/src/categories.rs

@@ -118,6 +118,7 @@ define_categories! {
     "lint/nursery/noDuplicateElseIf": "https://biomejs.dev/linter/rules/no-duplicate-else-if",
     "lint/nursery/noDuplicateFontNames": "https://biomejs.dev/linter/rules/no-font-family-duplicate-names",
     "lint/nursery/noDuplicateJsonKeys": "https://biomejs.dev/linter/rules/no-duplicate-json-keys",
+    "lint/nursery/noDuplicateSelectorsKeyframeBlock": "https://biomejs.dev/linter/rules/no-duplicate-selectors-keyframe-block",
     "lint/nursery/noEvolvingAny": "https://biomejs.dev/linter/rules/no-evolving-any",
     "lint/nursery/noFlatMapIdentity": "https://biomejs.dev/linter/rules/no-flat-map-identity",
     "lint/nursery/noMisplacedAssertion": "https://biomejs.dev/linter/rules/no-misplaced-assertion",