test: add more test cases

biomejs · Apr 20, 2024 · 7b3e87a · 7b3e87a
1 parent a4a5d10
commit 7b3e87a
Show file tree

Hide file tree

Showing 7 changed files with 97 additions and 11 deletions.
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs
diff --git a/crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css b/crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css
@@ -2,4 +2,12 @@
 
 @keyframes foo { from {} FROM {}}
 
-@keyframes foo { 0% {} 0% {}}
+@keyframes foo { 0% {} 0% {}}
+
+@keyframes foo { from {} to {} to {} }
+
+@keyframes foo { 0% {} 0% {} 100% {} }
+
+@-webkit-keyframes foo { 0% {} 0% {} 100% {} }
+
+@-moz-keyframes foo { 0% {} 0% {} 100% {} }
diff --git a/.../biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css.snap b/.../biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css.snap
@@ -9,6 +9,14 @@ expression: invalid.css
 @keyframes foo { from {} FROM {}}
 
 @keyframes foo { 0% {} 0% {}}
+
+@keyframes foo { from {} to {} to {} }
+
+@keyframes foo { 0% {} 0% {} 100% {} }
+
+@-webkit-keyframes foo { 0% {} 0% {} 100% {} }
+
+@-moz-keyframes foo { 0% {} 0% {} 100% {} }
 ```
 
 # Diagnostics
@@ -22,7 +30,7 @@ invalid.css:1:26 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━
     2 │ 
     3 │ @keyframes foo { from {} FROM {}}
   
-  i Consider using different selector here!
+  i Consider using a different percentage value or keyword to avoid duplication
   
 
 ```
@@ -39,7 +47,7 @@ invalid.css:3:26 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━
     4 │ 
     5 │ @keyframes foo { 0% {} 0% {}}
   
-  i Consider using different selector here!
+  i Consider using a different percentage value or keyword to avoid duplication
   
 
 ```
@@ -53,8 +61,76 @@ invalid.css:5:24 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━
     4 │ 
   > 5 │ @keyframes foo { 0% {} 0% {}}
       │                        ^^
+    6 │ 
+    7 │ @keyframes foo { from {} to {} to {} }
+  
+  i Consider using a different percentage value or keyword to avoid duplication
+  
+
+```
+
+```
+invalid.css:7:32 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: to
+  
+    5 │ @keyframes foo { 0% {} 0% {}}
+    6 │ 
+  > 7 │ @keyframes foo { from {} to {} to {} }
+      │                                ^^
+    8 │ 
+    9 │ @keyframes foo { 0% {} 0% {} 100% {} }
+  
+  i Consider using a different percentage value or keyword to avoid duplication
+  
+
+```
+
+```
+invalid.css:9:24 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: 0%
+  
+     7 │ @keyframes foo { from {} to {} to {} }
+     8 │ 
+   > 9 │ @keyframes foo { 0% {} 0% {} 100% {} }
+       │                        ^^
+    10 │ 
+    11 │ @-webkit-keyframes foo { 0% {} 0% {} 100% {} }
+  
+  i Consider using a different percentage value or keyword to avoid duplication
+  
+
+```
+
+```
+invalid.css:11:32 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: 0%
+  
+     9 │ @keyframes foo { 0% {} 0% {} 100% {} }
+    10 │ 
+  > 11 │ @-webkit-keyframes foo { 0% {} 0% {} 100% {} }
+       │                                ^^
+    12 │ 
+    13 │ @-moz-keyframes foo { 0% {} 0% {} 100% {} }
+  
+  i Consider using a different percentage value or keyword to avoid duplication
+  
+
+```
+
+```
+invalid.css:13:29 lint/nursery/noDuplicateSelectorsKeyframeBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Unexpected duplicate selector: 0%
+  
+    11 │ @-webkit-keyframes foo { 0% {} 0% {} 100% {} }
+    12 │ 
+  > 13 │ @-moz-keyframes foo { 0% {} 0% {} 100% {} }
+       │                             ^^
   
-  i Consider using different selector here!
+  i Consider using a different percentage value or keyword to avoid duplication
   
 
 ```
diff --git a/crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css b/crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css
@@ -1,3 +1,3 @@
-@keyframes foo { from {} to {}}
+@keyframes foo { from {} to {} }
 
-@keyframes foo { 0% {} 100% {}}
+@keyframes foo { 0% {} 100% {} }
diff --git a/...es/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css.snap b/...es/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/valid.css.snap
@@ -4,7 +4,7 @@ expression: valid.css
 ---
 # Input
 ```css
-@keyframes foo { from {} to {}}
+@keyframes foo { from {} to {} }
 
-@keyframes foo { 0% {} 100% {}}
+@keyframes foo { 0% {} 100% {} }
 ```
diff --git a/packages/@biomejs/backend-jsonrpc/src/workspace.ts b/packages/@biomejs/backend-jsonrpc/src/workspace.ts
diff --git a/packages/@biomejs/biome/configuration_schema.json b/packages/@biomejs/biome/configuration_schema.json