Skip to content

Conversation

superdump
Copy link
Contributor

@superdump superdump commented Dec 2, 2020

I saw @cart's PR #972 and was curious about how much it improved the impact of text rendering on frame rate in general so that one can have a HUD displaying frame time and frame rate. The answer (on a MacBook Pro 16" with Radeon Pro 5500M) is... before:

Screenshot 2020-12-02 at 16 38 44

...after:

Screenshot 2020-12-02 at 16 45 37

Note that I disabled vsync in the example to see how fast it can really go! :)

@cart
Copy link
Member

cart commented Dec 2, 2020

Looks good to me (once you apply @memoryruins's suggestion and fix formatting)

@memoryruins memoryruins added the C-Examples An addition or correction to our examples label Dec 2, 2020
@superdump
Copy link
Contributor Author

Not sure how I missed the formatting change. I tend to run cargo fmt; cargo run --example text_debug or so. Oh well, fixed now.

@superdump
Copy link
Contributor Author

Looks good to me (once you apply @memoryruins's suggestion and fix formatting)

I guess you meant @amberkowalski 's suggestion? I thought the change to a With query was a better solution.

@cart
Copy link
Member

cart commented Dec 3, 2020

Nope I meant @memoryruins' suggestion (the with query)

@cart cart merged commit 71e2c7f into bevyengine:master Dec 3, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Examples An addition or correction to our examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants