Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentSize replacement fix #9753

Merged
merged 4 commits into from
Sep 18, 2023

Commits on Sep 10, 2023

  1. ContentSize

    If you remove a `ContentSize` component from a Bevy UI entity and then immediately replace it `ui_layout_system` will remove the measure func from the internal Taffy layout tree but no new measure func will be generated to replace it since it's the widget systems that are responsible for creating their respective measure funcs not `ui_layout_system`. The widget systems only perform updates on changes to their content, and don't check `ContentSize` for changes. This means that until the content is changed in some way, no content will be displayed by the node.
    
    This commit fixes this by performing `ui_layout_system`'s `ContentSize` removal detection and resolution first, before measure func updates and in the widget systems generating a new `Measure` when a  `ContentSize` component is added to a widget entity.
    ickshonpe committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e99c2b1 View commit details
    Browse the repository at this point in the history
  2. cargo fmt --all

    ickshonpe committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    be79532 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    8f220a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a52bb6 View commit details
    Browse the repository at this point in the history