Fix errors and panics to typical Rust conventions #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambeeeeee
suggested changes
Dec 1, 2020
Contributor
ambeeeeee
left a comment
ambeeeeee
left a comment
There was a problem hiding this comment.
Interesting that the only previously consistently capitalized errors are the ones that should not be capitalized :(
memoryruins
added
the
C-Code-Quality
joshuajbouw
force-pushed
the
std-error
branch
from
faf182f to
f7309c0
Compare
Member
|
Looks good to me. Haha I have a feeling it will take some time for my brain to adjust to this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rust has such a nice error and panic display, its best to follow the conventions of it to make grammatical sense. This generally is sentence fragments for errors, and then full sentences for panics. Tried to catch as many as I could.
Just a wee bit of clean up.