Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI batching Fix #9610

Merged
merged 6 commits into from
Nov 3, 2023
Merged

UI batching Fix #9610

merged 6 commits into from
Nov 3, 2023

Commits on Aug 28, 2023

  1. Fixed UI batching so new batches aren't created for untextured nodes. 

    Thee initial value of `batch_image_handle` is changed from `HandleId::Id(Uuid::nil(), u64::MAX)` to `DEFAULT_IMAGE_HANDLE.id()`, which allowed me to make the if-block simpler I think.

The default image from `DEFAULT_IMAGE_HANDLE` is always inserted into `UiImageBindGroups` even if it's not used. I tried to add a check and only add it if there is only one batch but this crashed.
    @ickshonpe
    ickshonpe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1f476cb View commit details
    Browse the repository at this point in the history

  2. cargo fmt --all

    @ickshonpe
    ickshonpe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6891a81 View commit details
    Browse the repository at this point in the history

  3. Fixed panic, can't just unwrap the last element from batches to chang… 

    …e the texture handle as we might not have created any batches yet.
    @ickshonpe
    ickshonpe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4196697 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Fixed batching to use minimal draw calls again.

    @ickshonpe
    ickshonpe committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0f9f483 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ui-batching-fix-2' into ui-batching-fix

    @ickshonpe
    ickshonpe committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2da0c86 View commit details
    Browse the repository at this point in the history

  3. cargo fmt --all

    @ickshonpe
    ickshonpe committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2b5dac4 View commit details
    Browse the repository at this point in the history