Fix panic when using .load_folder() with absolute paths

[rlidwka]

Fixes #9458.

On case-insensitive filesystems (Windows, Mac, NTFS mounted in Linux, etc.), a path can be represented in a multiple ways:

• c:\users\user\rust\assets\hello\world
• c:/users/user/rust/assets/hello/world
• C:\USERS\USER\rust\assets\hello\world

If user specifies a path variant that doesn't match asset folder path bevy calculates, path.strip_prefix() will fail, as demonstrated below:

dbg!(Path::new("c:/foo/bar/baz").strip_prefix("c:/foo"));
// Ok("bar/baz")

dbg!(Path::new("c:/FOO/bar/baz").strip_prefix("c:/foo"));
// StripPrefixError(())

This commit rewrites the code in question in a way that prefix stripping is no longer necessary.

I've tested with the following paths on my computer:

let res = asset_server.load_folder("C:\\Users\\user\\rust\\assets\\foo\\bar");
dbg!(res);

let res = asset_server.load_folder("c:\\users\\user\\rust\\assets\\foo\\bar");
dbg!(res);

let res = asset_server.load_folder("C:/Users/user/rust/assets/foo/bar");
dbg!(res);

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[github-actions]

Example alien_cake_addict failed to run, please try running it locally and check the result.

[bushrat011899]

Just tested some examples, nice change! As a note, it does change the normal behaviour of read_directory when given a path that is relative to the root. Now it will always return absolute paths instead of paths relative to AssetIo::root_path. As the examples still work I don't think this is a breaking change, but it does change how this function works beyond just fixing the panic!.

Edit: This was mistaken on my part, please disregard!

[rlidwka]

Now it will always return absolute paths instead of paths relative to AssetIo::root_path.

It will return relative path if path parameter is relative (that's the most common case, and there're no changes there).

It will return absolute path if path parameter is absolute (before it was sometimes relative, and sometimes panic).

[alice-i-cecile]

@bushrat011899 if you're happy with the change and think it's ready to merge, can you please leave a review using Github's system? Bevy works on "community reviews", and your opinion will get us halfway there to merging this :)

[bushrat011899]

Simple solution, thanks for making it!

[Shatur]

Great, this fixes #5770.