Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temporal jitter bug #9462

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix temporal jitter bug #9462

merged 2 commits into from
Aug 17, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Aug 17, 2023 •
edited
Loading

  • Fixed jitter being applied in the wrong coordinate space, leading to aliasing.
  • Fixed incorrectly using the cached view_proj instead of account for temporal jitter.
  • Added a diagram to ensure the coordinate space is clear.

Before:
image

After:
image

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Aug 17, 2023
@JMS55 JMS55 added this to the 0.11.2 milestone Aug 17, 2023
@JMS55 JMS55 requested a review from cart August 17, 2023 00:41
@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

@cart cart added this pull request to the merge queue Aug 17, 2023
Merged via the queue into bevyengine:main with commit 5fac1fe Aug 17, 2023
19 of 20 checks passed
cart pushed a commit that referenced this pull request Aug 17, 2023
@JMS55 @cart
Fix temporal jitter bug (#9462)
94e81c2 
* Fixed jitter being applied in the wrong coordinate space, leading to
aliasing.
* Fixed incorrectly using the cached view_proj instead of account for
temporal jitter.
* Added a diagram to ensure the coordinate space is clear.

Before:

![image](https://github.com/bevyengine/bevy/assets/47158642/55b4bed4-4fb0-4fb2-a271-cc10a987e4d7)

After:

![image](https://github.com/bevyengine/bevy/assets/47158642/cbde4553-4e35-44d9-8ccf-f3a06e64a31f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elabajaba Elabajaba Elabajaba left review comments

@cart cart cart approved these changes

@DGriffin91 DGriffin91 DGriffin91 approved these changes

@inodentry inodentry inodentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.
5 participants
@JMS55 @Elabajaba @cart @DGriffin91 @inodentry