Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move window.rs to window/mod.rs in bevy_render #9394

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Move window.rs to window/mod.rs in bevy_render #9394

merged 1 commit into from
Aug 11, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Aug 9, 2023

Objective

Bevy prefers mod.rs inside module_name files over module_name.rs collocated with module_name. In bevy_render, it seems the window modules didn't follow this convention

Solution

  • Follow the mod.rs convention.

@nicopap nicopap added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Aug 9, 2023
@nicopap nicopap added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 11, 2023
@mockersf mockersf added this pull request to the merge queue Aug 11, 2023
Merged via the queue into bevyengine:main with commit da41aa3 Aug 11, 2023
24 checks passed
@nicopap nicopap deleted the window-mod-rs branch August 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@DGriffin91 DGriffin91 DGriffin91 approved these changes

@JMS55 JMS55 JMS55 approved these changes

@Selene-Amanita Selene-Amanita Selene-Amanita approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicopap @mockersf @DGriffin91 @JMS55 @Selene-Amanita