store PipelineSpecialization.dynamic_bindings in HashSet #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambeeeeee
approved these changes
Nov 28, 2020
mrk-its
force-pushed
the
dynamic_bindings_fix
branch
from
89ad308 to
d2c1856
Compare
Moxinilian
added
C-Bug
|
Good catch! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just noticed many compilations of the same pipeline (with the same specialization) - it seems it is because RenderResourceBindings.iter_dynamic_bindings() iterates HashMap (so order is nondeterministic) and we are storing result in Vec.
I noticed this bug on web app with bevy_webgl2 backend, but it seems native applications using wgpu renderer may be also affected.