bevy_reflect: Fix combined field attributes #9322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Bug
MrGVSV
force-pushed
the
reflect-fix-multiple-field-attributes
branch
from
a727456
to
fa277e3
Compare
mockersf
reviewed
Jul 31, 2023
MrGVSV
force-pushed
the
reflect-fix-multiple-field-attributes
branch
from
fa277e3
to
3276660
Compare
nicopap
approved these changes
Aug 2, 2023
crates/bevy_reflect/bevy_reflect_derive/src/field_attributes.rs
Outdated
Show resolved
Hide resolved
mockersf
approved these changes
Aug 2, 2023
mockersf
added
the
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective
It seems the behavior of field attributes was accidentally broken at
some point. Take the following code:
```rust
#[derive(Reflect)]
struct Foo {
#[reflect(ignore, default)]
value: usize
}
```
The above code should simply mark `value` as ignored and specify a
default behavior. However, what this actually does is discard both.
That's especially a problem when we don't want the field to be be given
a `Reflect` or `FromReflect` bound (which is why we ignore it in the
first place).
This only happens when the attributes are combined into one. The
following code works properly:
```rust
#[derive(Reflect)]
struct Foo {
#[reflect(ignore)]
#[reflect(default)]
value: usize
}
```
## Solution
Cleaned up the field attribute parsing logic to support combined field
attributes.
---
## Changelog
- Fixed a bug where `Reflect` derive attributes on fields are not able
to be combined into a single attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
It seems the behavior of field attributes was accidentally broken at some point. Take the following code:
The above code should simply mark
valueas ignored and specify a default behavior. However, what this actually does is discard both. That's especially a problem when we don't want the field to be be given aReflectorFromReflectbound (which is why we ignore it in the first place).This only happens when the attributes are combined into one. The following code works properly:
Solution
Cleaned up the field attribute parsing logic to support combined field attributes.
Changelog
Reflectderive attributes on fields are not able to be combined into a single attribute