Implement reflect trait on new glam types (I64Vec and U64Vec) #9281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
MrGVSV
added
A-Reflection
MrGVSV
approved these changes
Jul 26, 2023
mockersf
approved these changes
Jul 30, 2023
mockersf
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Glam 0.24 added new glam types (
I64VecandU64Vec). However these are not reflectable unlike the other glam typesSolution
Implement reflect for these new types
Changelog
Implements reflect with the impl_reflect_struct macro on
I64Vec2,I64Vec3,I64Vec4,U64Vec2,U64Vec3, andU64Vec4types