Update Camera's Frustum only when its GlobalTransform or CameraProjection changed
#9092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selene-Amanita
added
A-Rendering
cart
approved these changes
Aug 10, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
…aProjection` changed (#9092) # Objective Update a camera's frustum only when needed. - Maybe a performance gain from not having to compute frusta when not needed, at the cost of change detection (?) - Making "fighting" with `update_frusta` less tedious, see #9077 and https://discord.com/channels/691052431525675048/743663924229963868/1127566087966433322 ## Solution Add change detection filter for `GlobalTransform` or `T: CameraProjection` in `update_frusta`, since those are the cases when the frustum needs to be updated. ## Note I don't think a migration guide and changelog are needed, but I'm not 100% sure, I could put something like "if you're fighting against `update_frusta`, you can do it only when there is a change to `GlobalTransform` or `CameraProjection` now", what do you think? It's not really a breaking change with a normal use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Update a camera's frustum only when needed.
update_frustaless tedious, see Using a custom CameraProjection and directional light shadows crash #9077 and https://discord.com/channels/691052431525675048/743663924229963868/1127566087966433322Solution
Add change detection filter for
GlobalTransformorT: CameraProjectioninupdate_frusta, since those are the cases when the frustum needs to be updated.Note
I don't think a migration guide and changelog are needed, but I'm not 100% sure, I could put something like "if you're fighting against
update_frusta, you can do it only when there is a change toGlobalTransformorCameraProjectionnow", what do you think? It's not really a breaking change with a normal use case.