Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gizmo line width issue when using perspective #9067

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix gizmo line width issue when using perspective #9067

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04661cb
fix line with perspective
IceSentry Jul 7, 2023
81c5721
Merge branch 'main' into line-persp
mockersf Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/bevy_gizmos/src/lines.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ fn vertex(vertex: VertexInput) -> VertexOutput {
#endif

// Line thinness fade from https://acegikmo.com/shapes/docs/#anti-aliasing
if line_width < 1. {
if line_width > 0.0 && line_width < 1. {
color.a *= line_width;
line_width = 1.;
}
Expand All @@ -79,10 +79,10 @@ fn vertex(vertex: VertexInput) -> VertexOutput {
let epsilon = 4.88e-04;
// depth * (clip.w / depth)^-depth_bias. So that when -depth_bias is 1.0, this is equal to clip.w
// and when equal to 0.0, it is exactly equal to depth.
// the epsilon is here to prevent the depth from exceeding clip.w when -depth_bias = 1.0
// the epsilon is here to prevent the depth from exceeding clip.w when -depth_bias = 1.0
// clip.w represents the near plane in homogenous clip space in bevy, having a depth
// of this value means nothing can be in front of this
// The reason this uses an exponential function is that it makes it much easier for the
// The reason this uses an exponential function is that it makes it much easier for the
// user to chose a value that is convinient for them
depth = clip.z * exp2(-line_gizmo.depth_bias * log2(clip.w / clip.z - epsilon));
}
Expand Down