Touchpad magnify and rotate events #8791
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Feature
crates/bevy_input/src/mouse.rs
Outdated
| /// | ||
| /// - Only available on **`macOS`**. | ||
| #[derive(Event, Debug, Clone, Copy, PartialEq, Reflect, FromReflect)] | ||
| #[reflect(Debug, PartialEq)] |
There was a problem hiding this comment.
Could you also add FromReflect to this attribute?
There was a problem hiding this comment.
Isn't that already the case? It is the last argument to #[derive(...)].
There was a problem hiding this comment.
Sorry, to clarify I’m referring to adding a ReflectFromReflect registration like #[reflect(Debug, PartialEq, FromReflect)]
There was a problem hiding this comment.
Oh I see. I've added it to #[reflect(...)] but the reason for it not being initially there is that none of the types in bevy_input::mouse use it. So its probably missing there as well, right? Or is that intentional?
There was a problem hiding this comment.
Yeah it should be there as well. #8776 addresses that issue.
crates/bevy_input/src/mouse.rs
Outdated
| /// | ||
| /// - Only available on **`macOS`**. | ||
| #[derive(Event, Debug, Clone, Copy, PartialEq, Reflect, FromReflect)] | ||
| #[reflect(Debug, PartialEq)] |
crates/bevy_input/src/mouse.rs
Outdated
| derive(serde::Serialize, serde::Deserialize), | ||
| reflect(Serialize, Deserialize) | ||
| )] | ||
| pub struct Magnify(pub f32); |
There was a problem hiding this comment.
Should these also be prefixed with Touchpad for clarity?
There was a problem hiding this comment.
I moved these types into their own module as I think that this is more future proof.
There was a problem hiding this comment.
I feel like they should still be renamed to tie them back to the touchpad. Rotate especially is pretty generic and could be confusing to some users.
mockersf
added
the
S-Ready-For-Final-Review
Objective
The goal of this PR is to receive touchpad magnification and rotation events.
Solution
Implement pendants for winit's
TouchpadMagnifyandTouchpadRotateevents.Adjust the
mouse_input_events.rsexample to debug magnify and rotate events.Since winit only reports these events on macOS, the Bevy events for touchpad magnification and rotation are currently only fired on macOS.