Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy_reflect: Add ReflectFromReflect to the prelude #8496

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Apr 26, 2023

Objective

Considering that FromReflect is a very common trait to derive, it would make sense to include ReflectFromReflect in the bevy_reflect prelude so users don't need to import it separately.

Solution

Add ReflectFromReflect to the prelude.

@MrGVSV MrGVSV added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Apr 26, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 26, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 26, 2023
Merged via the queue into bevyengine:main with commit 74d4252 Apr 26, 2023
@MrGVSV MrGVSV deleted the reflect-from-reflect-prelude branch April 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants