Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure_text_system text query fix #8466

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

ickshonpe
Copy link
Contributor

Objective

The first query of measure_text_system's text_queries ParamSet queries for all changed Text meaning that non-UI Text entities could be added to its queue.

Solution

Add a With<Node> query filter.


Changelog

changes:

  • Added a With<Node> query filter to first query of measure_text_system's text_queries ParamSet to ensure that only UI node entities are added to its local queue.
  • Fixed comment (text is not computed on changes to style).

* Added a `With<Node>` query filter to first query of `measure_text_system`'s `text_queries` `ParamSet` to ensure that only UI node entities are added to its local queue.
* Fixed comment (text is not computed on changes to style).
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Apr 22, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 22, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 22, 2023
Merged via the queue into bevyengine:main with commit 4580a91 Apr 22, 2023
Estus-Dev pushed a commit to Estus-Dev/bevy that referenced this pull request Jul 10, 2023
# Objective

The first query of `measure_text_system`'s `text_queries` `ParamSet`
queries for all changed `Text` meaning that non-UI `Text` entities could
be added to its queue.

## Solution

Add a `With<Node>` query filter.

---

## Changelog
changes:
* Added a `With<Node>` query filter to first query of
`measure_text_system`'s `text_queries` `ParamSet` to ensure that only UI
node entities are added to its local queue.
* Fixed comment (text is not computed on changes to style).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants