Remove the corresponding measure from Taffy when a CalculatedSize component is removed.
#8294
Conversation
| @@ -320,6 +328,11 @@ pub fn flex_node_system( | |||
| // clean up removed nodes | |||
| flex_surface.remove_entities(removed_nodes.iter()); | |||
|
|
|||
| // When a `CalculatedSize` component is removed from an entity, we need to remove the measure from the corresponding taffy node. | |||
| for entity in removed_calculated_sizes.iter() { | |||
There was a problem hiding this comment.
What would you think about moving this into a separate system?
This one seems to be getting quite big and doing a lot of different things.
There was a problem hiding this comment.
Definitely needs to be done, and I found this bug while working on some other changes that require flex_node_system to be split up. I'm not quite sure how they'll work out yet though, so I just put in this PR that fixes the bug with minimal changes etc.
|
How challenging would it be to add a test for this? |
It's not too difficult, but |
james7132
added
C-Bug
Objective
When a
CalculatedSizecomponent from a UI Node entity is removed, the corresponding Taffy measure isn't removed which will mess up the layout in confusing, unpredictable ways.Solution
Iterate through all the entities with removed
CalculatedSizecomponents and remove the corresponding Taffy measures.